Fix lint for pinnedWorkflows.ts

thyeggman · thyeggman · commit e52da1770b89 · 2022-10-12T17:40:58.000-07:00
diff --git a/src/extension.ts b/src/extension.ts
@@ -40,14 +40,12 @@ export async function activate(context: vscode.ExtensionContext) {
   initResources(context);
 
   initConfiguration(context);
-  await initPinnedWorkflows(context);
+  await initPinnedWorkflows();
 
   // Track workflow
-  initWorkflowDocumentTracking(context);
+  await initWorkflowDocumentTracking(context);
 
-  //
   // Tree views
-  //
 
   const workflowTreeProvider = new WorkflowsTreeProvider();
   context.subscriptions.push(vscode.window.registerTreeDataProvider("github-actions.workflows", workflowTreeProvider));
@@ -143,7 +141,7 @@ export async function activate(context: vscode.ExtensionContext) {
 
   // Editing features
 
-  init(context);
+  await init(context);
 
   log("...initialized");
 }
diff --git a/src/pinnedWorkflows/pinnedWorkflows.ts b/src/pinnedWorkflows/pinnedWorkflows.ts
@@ -25,11 +25,11 @@ interface PinnedWorkflow {
 }
 
 const pinnedWorkflows: PinnedWorkflow[] = [];
-let refreshTimer: /*NodeJS.Timeout*/ any | undefined;
+let refreshTimer: NodeJS.Timeout | undefined;
 
-export async function initPinnedWorkflows(context: vscode.ExtensionContext) {
+export async function initPinnedWorkflows() {
   // Register handler for configuration changes
-  onPinnedWorkflowsChange(_init);
+  onPinnedWorkflowsChange(() => _init);
 
   await _init();
 }
@@ -42,7 +42,7 @@ async function _init() {
     refreshTimer = undefined;
   }
   if (isPinnedWorkflowsRefreshEnabled()) {
-    refreshTimer = setInterval(refreshPinnedWorkflows, pinnedWorkflowsRefreshInterval() * 1000);
+    refreshTimer = setInterval(() => refreshPinnedWorkflows, pinnedWorkflowsRefreshInterval() * 1000);
   }
 }
 
@@ -136,7 +136,7 @@ async function updatePinnedWorkflow(pinnedWorkflow: PinnedWorkflow) {
     const runs = await gitHubRepoContext.client.actions.listWorkflowRuns({
       owner: gitHubRepoContext.owner,
       repo: gitHubRepoContext.name,
-      workflow_id: pinnedWorkflow.workflowId as any, // Workflow can also be a file name
+      workflow_id: pinnedWorkflow.workflowId, // Workflow can also be a file name
       per_page: 1,
     });
     const { total_count, workflow_runs } = runs.data;

Original file line number	Diff line number	Diff line change
`@@ -25,11 +25,11 @@ interface PinnedWorkflow {`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`const pinnedWorkflows: PinnedWorkflow[] = [];`
`28`		`-let refreshTimer: /NodeJS.Timeout/ any \| undefined;`
	`28`	`+let refreshTimer: NodeJS.Timeout \| undefined;`
`29`	`29`
`30`		`-export async function initPinnedWorkflows(context: vscode.ExtensionContext) {`
	`30`	`+export async function initPinnedWorkflows() {`
`31`	`31`	`// Register handler for configuration changes`
`32`		`- onPinnedWorkflowsChange(_init);`
	`32`	`+ onPinnedWorkflowsChange(() => _init);`
`33`	`33`
`34`	`34`	`await _init();`
`35`	`35`	`}`
`@@ -42,7 +42,7 @@ async function _init() {`
`42`	`42`	`refreshTimer = undefined;`
`43`	`43`	`}`
`44`	`44`	`if (isPinnedWorkflowsRefreshEnabled()) {`
`45`		`- refreshTimer = setInterval(refreshPinnedWorkflows, pinnedWorkflowsRefreshInterval() * 1000);`
	`45`	`+ refreshTimer = setInterval(() => refreshPinnedWorkflows, pinnedWorkflowsRefreshInterval() * 1000);`
`46`	`46`	`}`
`47`	`47`	`}`
`48`	`48`
`@@ -136,7 +136,7 @@ async function updatePinnedWorkflow(pinnedWorkflow: PinnedWorkflow) {`
`136`	`136`	`const runs = await gitHubRepoContext.client.actions.listWorkflowRuns({`
`137`	`137`	`owner: gitHubRepoContext.owner,`
`138`	`138`	`repo: gitHubRepoContext.name,`
`139`		`- workflow_id: pinnedWorkflow.workflowId as any, // Workflow can also be a file name`
	`139`	`+ workflow_id: pinnedWorkflow.workflowId, // Workflow can also be a file name`
`140`	`140`	`per_page: 1,`
`141`	`141`	`});`
`142`	`142`	`const { total_count, workflow_runs } = runs.data;`