Fix linting for tree node files

thyeggman · thyeggman · commit db0893c70843 · 2022-10-12T15:34:07.000-07:00
diff --git a/src/treeViews/current-branch/currentBranchRepoNode.ts b/src/treeViews/current-branch/currentBranchRepoNode.ts
@@ -44,8 +44,6 @@ export async function getCurrentBranchWorkflowRunNodes(
   }
 
   return runs.map((wr) => {
-    const wf = wr.workflow_id;
-
     // TODO: Do we need to include the workflow name here?
     return new WorkflowRunNode(gitHubRepoContext, wr, wr.name ?? undefined);
   });
diff --git a/src/treeViews/icons.ts b/src/treeViews/icons.ts
@@ -39,6 +39,7 @@ function _getIconForWorkflowrun(
         case "cancelled":
           return getAbsoluteIconPath("conclusions/cancelled.svg");
       }
+      break;
     }
 
     case "queued":
@@ -73,6 +74,7 @@ export function getCodIconForWorkflowrun(runOrJob?: IStatusAndConclusion): strin
         case "cancelled":
           return "circle-slash";
       }
+      break;
     }
 
     case "queued":
diff --git a/src/treeViews/settings/settingsRepoNode.ts b/src/treeViews/settings/settingsRepoNode.ts
@@ -13,7 +13,7 @@ export class SettingsRepoNode extends vscode.TreeItem {
     this.contextValue = "settings-repo";
   }
 
-  async getSettings(): Promise<SettingsExplorerNode[]> {
+  getSettings(): SettingsExplorerNode[] {
     return getSettingNodes(this.gitHubRepoContext);
   }
 }
diff --git a/src/treeViews/workflows.ts b/src/treeViews/workflows.ts
@@ -54,14 +54,14 @@ export class WorkflowsTreeProvider implements vscode.TreeDataProvider<WorkflowsT
 
         log("No GitHub repositories found");
         return [];
-      } catch (e: any) {
+      } catch (e: unknown) {
         logError(e as Error, "Failed to get GitHub context");
 
-        if (`${e?.message}`.startsWith("Could not get token from the GitHub authentication provider.")) {
+        if (`${(e as Error).message}`.startsWith("Could not get token from the GitHub authentication provider.")) {
           return [new AuthenticationNode()];
         }
 
-        return [new ErrorNode(`An error has occured: ${e.message}`)];
+        return [new ErrorNode(`An error has occured: ${(e as Error).message}`)];
       }
     }
 
diff --git a/src/treeViews/workflows/workflowJobNode.ts b/src/treeViews/workflows/workflowJobNode.ts
@@ -20,7 +20,7 @@ export class WorkflowJobNode extends vscode.TreeItem {
     return !!(this.job.steps && this.job.steps.length > 0);
   }
 
-  async getSteps(): Promise<WorkflowStepNode[]> {
+  getSteps(): WorkflowStepNode[] {
     return (this.job.steps || []).map((s) => new WorkflowStepNode(this.gitHubRepoContext, this.job, s));
   }
 }
diff --git a/src/treeViews/workflows/workflowRunNode.ts b/src/treeViews/workflows/workflowRunNode.ts
@@ -31,7 +31,7 @@ export class WorkflowRunNode extends vscode.TreeItem {
     }
 
     this.iconPath = getIconForWorkflowRun(this.run);
-    this.tooltip = `${this.run.status} ${this.run.conclusion || ""}`;
+    this.tooltip = `${this.run.status || ""} ${this.run.conclusion || ""}`;
   }
 
   async getJobs(): Promise<WorkflowJobNode[]> {
@@ -44,7 +44,7 @@ export class WorkflowRunNode extends vscode.TreeItem {
     });
 
     const resp = result.data;
-    const jobs: WorkflowJob[] = (resp as any).jobs;
+    const jobs: WorkflowJob[] = resp.jobs;
 
     return jobs.map((job) => new WorkflowJobNode(this.gitHubRepoContext, job));
   }

Original file line number	Diff line number	Diff line change
`@@ -44,8 +44,6 @@ export async function getCurrentBranchWorkflowRunNodes(`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`return runs.map((wr) => {`
`47`		`- const wf = wr.workflow_id;`
`48`		`-`
`49`	`47`	`// TODO: Do we need to include the workflow name here?`
`50`	`48`	`return new WorkflowRunNode(gitHubRepoContext, wr, wr.name ?? undefined);`
`51`	`49`	`});`
Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,7 @@ function _getIconForWorkflowrun(`
`39`	`39`	`case "cancelled":`
`40`	`40`	`return getAbsoluteIconPath("conclusions/cancelled.svg");`
`41`	`41`	`}`
	`42`	`+ break;`
`42`	`43`	`}`
`43`	`44`
`44`	`45`	`case "queued":`
`@@ -73,6 +74,7 @@ export function getCodIconForWorkflowrun(runOrJob?: IStatusAndConclusion): strin`
`73`	`74`	`case "cancelled":`
`74`	`75`	`return "circle-slash";`
`75`	`76`	`}`
	`77`	`+ break;`
`76`	`78`	`}`
`77`	`79`
`78`	`80`	`case "queued":`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ export class SettingsRepoNode extends vscode.TreeItem {`
`13`	`13`	`this.contextValue = "settings-repo";`
`14`	`14`	`}`
`15`	`15`
`16`		`- async getSettings(): Promise<SettingsExplorerNode[]> {`
	`16`	`+ getSettings(): SettingsExplorerNode[] {`
`17`	`17`	`return getSettingNodes(this.gitHubRepoContext);`
`18`	`18`	`}`
`19`	`19`	`}`
Original file line number	Diff line number	Diff line change
`@@ -54,14 +54,14 @@ export class WorkflowsTreeProvider implements vscode.TreeDataProvider<WorkflowsT`
`54`	`54`
`55`	`55`	`log("No GitHub repositories found");`
`56`	`56`	`return [];`
`57`		`- } catch (e: any) {`
	`57`	`+ } catch (e: unknown) {`
`58`	`58`	`logError(e as Error, "Failed to get GitHub context");`
`59`	`59`
`60`		- if (`${e?.message}`.startsWith("Could not get token from the GitHub authentication provider.")) {
	`60`	+ if (`${(e as Error).message}`.startsWith("Could not get token from the GitHub authentication provider.")) {
`61`	`61`	`return [new AuthenticationNode()];`
`62`	`62`	`}`
`63`	`63`
`64`		- return [new ErrorNode(`An error has occured: ${e.message}`)];
	`64`	+ return [new ErrorNode(`An error has occured: ${(e as Error).message}`)];
`65`	`65`	`}`
`66`	`66`	`}`
`67`	`67`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ export class WorkflowJobNode extends vscode.TreeItem {`
`20`	`20`	`return !!(this.job.steps && this.job.steps.length > 0);`
`21`	`21`	`}`
`22`	`22`
`23`		`- async getSteps(): Promise<WorkflowStepNode[]> {`
	`23`	`+ getSteps(): WorkflowStepNode[] {`
`24`	`24`	`return (this.job.steps \|\| []).map((s) => new WorkflowStepNode(this.gitHubRepoContext, this.job, s));`
`25`	`25`	`}`
`26`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ export class WorkflowRunNode extends vscode.TreeItem {`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`this.iconPath = getIconForWorkflowRun(this.run);`
`34`		- this.tooltip = `${this.run.status} ${this.run.conclusion \|\| ""}`;
	`34`	+ this.tooltip = `${this.run.status \|\| ""} ${this.run.conclusion \|\| ""}`;
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`async getJobs(): Promise<WorkflowJobNode[]> {`
`@@ -44,7 +44,7 @@ export class WorkflowRunNode extends vscode.TreeItem {`
`44`	`44`	`});`
`45`	`45`
`46`	`46`	`const resp = result.data;`
`47`		`- const jobs: WorkflowJob[] = (resp as any).jobs;`
	`47`	`+ const jobs: WorkflowJob[] = resp.jobs;`
`48`	`48`
`49`	`49`	`return jobs.map((job) => new WorkflowJobNode(this.gitHubRepoContext, job));`
`50`	`50`	`}`