Always fetch jobs when updating in-progress runs

joshmgross · joshmgross · commit c4959f73db87 · 2023-01-31T11:26:09.000-05:00
diff --git a/src/store/workflowRun.ts b/src/store/workflowRun.ts
@@ -33,11 +33,9 @@ abstract class WorkflowRunBase {
   }
 
   updateRun(run: model.WorkflowRun) {
-    if (this._run.updated_at !== run.updated_at) {
-      // Run has changed, reset jobs. Note: this doesn't work in all cases, there might be race conditions
-      // where the run update_at field isn't set but the jobs change, but in the vast majority of cases the
-      // combined status/conclusion of the run is updated whenever a job changes, so this should be good enough
-      // for now to reduce the # of API calls
+    if (this._run.status !== "completed" || this._run.updated_at !== run.updated_at) {
+      // Refresh jobs if the run is not completed or it was updated (i.e. re-run)
+      // For in-progress runs, we can't rely on updated at to change when jobs change
       this._jobs = undefined;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -33,11 +33,9 @@ abstract class WorkflowRunBase {`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`updateRun(run: model.WorkflowRun) {`
`36`		`- if (this._run.updated_at !== run.updated_at) {`
`37`		`- // Run has changed, reset jobs. Note: this doesn't work in all cases, there might be race conditions`
`38`		`- // where the run update_at field isn't set but the jobs change, but in the vast majority of cases the`
`39`		`- // combined status/conclusion of the run is updated whenever a job changes, so this should be good enough`
`40`		`- // for now to reduce the # of API calls`
	`36`	`+ if (this._run.status !== "completed" \|\| this._run.updated_at !== run.updated_at) {`
	`37`	`+ // Refresh jobs if the run is not completed or it was updated (i.e. re-run)`
	`38`	`+ // For in-progress runs, we can't rely on updated at to change when jobs change`
`41`	`39`	`this._jobs = undefined;`
`42`	`40`	`}`
`43`	`41`