Support adding new secrets

cschleiden · cschleiden · commit acf705271e37 · 2020-01-09T16:05:43.000-08:00
diff --git a/package.json b/package.json
@@ -65,10 +65,21 @@
         "title": "Cancel workflow run",
         "when": "viewItem =~ /run/ && viewItem =~ /cancelable/"
       },
+      {
+        "command": "settings.secret.add",
+        "title": "Add new secret",
+        "icon": {
+          "dark": "resources/icons/dark/add.svg",
+          "light": "resources/icons/light/add.svg"
+        }
+      },
       {
         "command": "settings.secret.update",
-        "title": "Update secret",
-        "when": "viewItem == 'secret'"
+        "title": "Update secret"
+      },
+      {
+        "command": "settings.secret.delete",
+        "title": "Delete secret"
       }
     ],
     "views": {
@@ -121,9 +132,18 @@
           "command": "workflow.run.rerun",
           "when": "viewItem =~ /run/ && viewItem =~ /rerunnable/"
         },
+        {
+          "command": "settings.secret.add",
+          "group": "inline",
+          "when": "viewItem == 'secrets'"
+        },
         {
           "command": "settings.secret.update",
           "when": "viewItem == 'secret'"
+        },
+        {
+          "command": "settings.secret.delete",
+          "when": "viewItem == 'secret'"
         }
       ]
     }
diff --git a/resources/icons/dark/add.svg b/resources/icons/dark/add.svg
@@ -0,0 +1 @@
+<svg width="16" height="16" xmlns="http://www.w3.org/2000/svg"><title>Layer 1</title><rect height="11" width="3" y="3" x="7" fill="#C5C5C5"/><rect height="3" width="11" y="7" x="3" fill="#C5C5C5"/></svg>
diff --git a/resources/icons/light/add.svg b/resources/icons/light/add.svg
@@ -0,0 +1 @@
+<svg width="16" height="16" xmlns="http://www.w3.org/2000/svg"><title>Layer 1</title><rect height="11" width="3" y="3" x="7" fill="#424242"/><rect height="3" width="11" y="7" x="3" fill="#424242"/></svg>
diff --git a/src/extension.ts b/src/extension.ts
@@ -156,6 +156,68 @@ export function activate(context: vscode.ExtensionContext) {
     })
   );
 
+  context.subscriptions.push(
+    vscode.commands.registerCommand("settings.secret.add", async args => {
+      const repo: Protocol = args.repo;
+      const client: OctokitWithActions = args.client;
+
+      const name = await vscode.window.showInputBox({
+        prompt: "Enter name for new secret"
+      });
+
+      if (!name) {
+        return;
+      }
+
+      const value = await vscode.window.showInputBox({
+        prompt: "Enter the new secret value"
+      });
+
+      if (value) {
+        try {
+          const keyResponse = await client.actions.getPublicKey({
+            owner: repo.owner,
+            repo: repo.repositoryName
+          });
+
+          const key_id: string = keyResponse.data.key_id;
+          const key: string = keyResponse.data.key;
+
+          await client.actions.setSecret({
+            owner: repo.owner,
+            repo: repo.repositoryName,
+            name: name,
+            key_id: key_id,
+            encrypted_value: encodeSecret(key, value)
+          });
+        } catch (e) {
+          vscode.window.showErrorMessage(e.message);
+        }
+      }
+
+      settingsTreeProvider.refresh();
+    })
+  );
+
+  context.subscriptions.push(
+    vscode.commands.registerCommand("settings.secret.delete", async args => {
+      const repo: Protocol = args.repo;
+      const secret: Secret = args.secret;
+      const client: OctokitWithActions = args.client;
+
+      // TODO: Make API call
+      // await client.actions.setSecret({
+      //   owner: repo.owner,
+      //   repo: repo.repositoryName,
+      //   name: name,
+      //   key_id: key_id,
+      //   encrypted_value: encodeSecret(key, value)
+      // });
+
+      settingsTreeProvider.refresh();
+    })
+  );
+
   context.subscriptions.push(
     vscode.commands.registerCommand("settings.secret.update", async args => {
       const repo: Protocol = args.repo;
diff --git a/src/treeViews/settings.ts b/src/treeViews/settings.ts
@@ -14,8 +14,13 @@ class SelfHostedRunnersNode extends vscode.TreeItem {
 }
 
 class SecretsNode extends vscode.TreeItem {
-  constructor(public client: OctokitWithActions) {
+  constructor(
+    public readonly repo: Protocol,
+    public readonly client: OctokitWithActions
+  ) {
     super("Secrets", vscode.TreeItemCollapsibleState.Collapsed);
+
+    this.contextValue = "secrets";
   }
 }
 
@@ -69,7 +74,7 @@ export class SettingsTreeProvider
 
     if (!element) {
       // Root
-      return [new SelfHostedRunnersNode(), new SecretsNode(client)];
+      return [new SelfHostedRunnersNode(), new SecretsNode(repo, client)];
     }
 
     if (element instanceof SecretsNode) {

Original file line number	Diff line number	Diff line change
`@@ -14,8 +14,13 @@ class SelfHostedRunnersNode extends vscode.TreeItem {`
`14`	`14`	`}`
`15`	`15`
`16`	`16`	`class SecretsNode extends vscode.TreeItem {`
`17`		`- constructor(public client: OctokitWithActions) {`
	`17`	`+ constructor(`
	`18`	`+ public readonly repo: Protocol,`
	`19`	`+ public readonly client: OctokitWithActions`
	`20`	`+ ) {`
`18`	`21`	`super("Secrets", vscode.TreeItemCollapsibleState.Collapsed);`
	`22`	`+`
	`23`	`+ this.contextValue = "secrets";`
`19`	`24`	`}`
`20`	`25`	`}`
`21`	`26`
`@@ -69,7 +74,7 @@ export class SettingsTreeProvider`
`69`	`74`
`70`	`75`	`if (!element) {`
`71`	`76`	`// Root`
`72`		`- return [new SelfHostedRunnersNode(), new SecretsNode(client)];`
	`77`	`+ return [new SelfHostedRunnersNode(), new SecretsNode(repo, client)];`
`73`	`78`	`}`
`74`	`79`
`75`	`80`	`if (element instanceof SecretsNode) {`