fix linting rules in workflow.ts

thyeggman · thyeggman · commit 4f4fdc2bfbb9 · 2022-10-12T15:11:29.000-07:00
diff --git a/src/extension.ts b/src/extension.ts
@@ -91,7 +91,7 @@ export async function activate(context: vscode.ExtensionContext) {
         // When the current head/branch changes, or the number of commits ahead changes (which indicates
         // a push), refresh the current-branch view
         if (
-          (repo.repositoryState?.HEAD?.name ?? false) !== currentHeadName ||
+          repo.repositoryState?.HEAD?.name !== currentHeadName ||
           (repo.repositoryState?.HEAD?.ahead || 0) < (currentAhead || 0)
         ) {
           currentHeadName = repo.repositoryState?.HEAD?.name;
diff --git a/src/workflow/workflow.ts b/src/workflow/workflow.ts
@@ -13,8 +13,18 @@ interface On {
   schedule?: string[];
 }
 
-function getEvents(doc: any): On[] {
-  const trigger: string | string[] | { [trigger: string]: any | undefined } = doc.on;
+type EventTrigger = {
+  on: string | string[] | { [trigger: string]: string[] | undefined };
+}
+
+interface Trigger {
+  types?: string[];
+  branches?: string[];
+  schedule?: string[];
+}
+
+function getEvents(doc: string | object): On[] {
+  const trigger = (doc as EventTrigger).on;
 
   const on: On[] = [];
 
@@ -33,14 +43,13 @@ function getEvents(doc: any): On[] {
   } else if (typeof trigger == "object") {
     on.push(
       ...Object.keys(trigger).map((event) => {
-        // Work around typing :(
-        const t = (trigger as any)[event];
+        const t = (trigger as { [trigger: string]: Trigger | undefined })[event];
 
         return {
           event,
-          types: t?.types,
-          branches: t?.branches,
-          schedule: t?.schedule,
+          types: (t as Trigger).types,
+          branches: (t as Trigger).branches,
+          schedule: (t as Trigger).schedule,
         };
       })
     );
