Skip to content

[Python]: Add Server-side Request Forgery sinks #545

Closed

Description

@haby0

Query PR

github/codeql#8275

Language

Python

CVE(s) ID list

Other: https://lgtm.com/query/5777911924609612713/

CWE

CWE-918: Server-Side Request Forgery (SSRF)

Report

1.What is the vulnerability?
Add some sinks in the CodeQL-Python SSRF model. Modeled Python libraries are: Aiohttp, Httpx, Libtaxii, Urllib, Urllib2, Urllib3.

2.How does the vulnerability work?
The web server receives a URL or similar request from an upstream component and retrieves the contents of this URL, but it does not sufficiently ensure that the request is being sent to the expected destination.

3.What strategy do you use in your query to find the vulnerability?
Added some sinks on CodeQL-Python CWE-918 model.

4.What have you reduced the number of false positives?
Sanitizer has not been modeled yet.

5.Other information?
None.

Are you planning to discuss this vulnerability submission publicly? (Blog Post, social networks, etc).

  • Yes
  • No

Blog post link

No response

Activity

  1. added
    All For OneSubmissions to the All for One, One for All bounty
    on Feb 28, 2022
  2. haby0 commented on Mar 11, 2022

    @haby0
    Author

    github/codeql#8275 this PR has been merged.

  3. haby0 commented on Mar 18, 2022

    @haby0
    Author

    Ping.

  4. ghsecuritylab commented on Mar 25, 2022

    @ghsecuritylab
    Collaborator

    Your submission is now in status Test run.

    For information, the evaluation workflow is the following:
    Initial triage > Test run > Results analysis > Query review > Final decision > Pay > Closed

  5. ghsecuritylab commented on Apr 1, 2022

    @ghsecuritylab
    Collaborator

    Your submission is now in status Results analysis.

    For information, the evaluation workflow is the following:
    Initial triage > Test run > Results analysis > Query review > Final decision > Pay > Closed

  6. ghsecuritylab commented on Apr 1, 2022

    @ghsecuritylab
    Collaborator

    Your submission is now in status Final decision.

    For information, the evaluation workflow is the following:
    Initial triage > Test run > Results analysis > Query review > Final decision > Pay > Closed

  7. ghsecuritylab commented on Apr 11, 2022

    @ghsecuritylab
    Collaborator

    Your submission is now in status Pay.

    For information, the evaluation workflow is the following:
    Initial triage > Test run > Results analysis > Query review > Final decision > Pay > Closed

  8. xcorail commented on Apr 11, 2022

    @xcorail
    Contributor

    Created Hackerone report 1538144 for bounty 382663 : [545] [Python]: Add Server-side Request Forgery sinks

  9. ghsecuritylab commented on Apr 11, 2022

    @ghsecuritylab
    Collaborator

    Your submission is now in status Closed.

    For information, the evaluation workflow is the following:
    Initial triage > Test run > Results analysis > Query review > Final decision > Pay > Closed

  10. haby0 commented on Apr 12, 2022

    @haby0
    Author

    @xcorail Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    All For OneSubmissions to the All for One, One for All bounty

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions