Migrate set_issue_fields tool payload to using new intent model#2678
Open
reneexeener wants to merge 8 commits into
Open
Migrate set_issue_fields tool payload to using new intent model#2678reneexeener wants to merge 8 commits into
set_issue_fields tool payload to using new intent model#2678reneexeener wants to merge 8 commits into
Conversation
set_issue_fields tool payload to using new intent model
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new feature-flagged payload shape for the set_issue_fields GraphQL mutation, allowing rationale/confidence to be sent as a nested intent object to support an upcoming backend schema migration.
Changes:
- Introduces
IssueUpdateIntentInputand anIntentfield onIssueFieldCreateOrUpdateInput. - Updates
GranularSetIssueFieldsto conditionally send rationale/confidence via nestedintentvs flat fields based on a feature flag. - Adds a unit test validating the nested intent payload when the feature flag is enabled.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/issues_granular.go | Adds nested intent input type and gates the outgoing mutation payload shape behind a feature flag. |
| pkg/github/granular_tools_test.go | Adds a test case asserting the nested intent payload is used when the flag is enabled. |
| pkg/github/feature_flags.go | Defines the new feature flag constant used to gate the payload shape. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 2
Comment on lines
+20
to
+24
| // rationale and confidence on issue field mutations as a nested `intent` | ||
| // object (IssueUpdateIntent) instead of as flat fields. It exists so the | ||
| // set_issue_fields tool can switch payload shapes while the backend migrates | ||
| // IssueFieldCreateOrUpdateInput from IssueEventRationale to IssueUpdateIntent. | ||
| const FeatureFlagIssueFieldsUseIntent = "issue_fields_use_intent" |
Author
There was a problem hiding this comment.
This is intentional because this feature flag shouldn't be user-facing. The feature flag issue_fields_use_intent will be rolled out after the GraphQL mutation is updated.
frogfx
reviewed
Jun 12, 2026
frogfx
left a comment
There was a problem hiding this comment.
Please check items before merge
- Add FF-disabled regression test
- Add partial/empty intent tests
- Clean up naming inconsistencies between PR text and code (update_intent vs intent, flag name mismatch if applicable)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new feature flag,
issue_fields_use_intent, and updates the issue field mutation logic to optionally send rationale and confidence as a nestedupdate_intentobject (instead of flat fields) when the flag is enabled, to support a backend schema migration.Why
We're migrating to storing suggestions in a new DB table so the GraphQL schema will change for the
set_issue_field_valuemutation to accept anintentargument. These changes are needed to make sure this MCP tool works with the upcoming schema change.What changed
This pull request introduces support for a new payload shape for issue field mutations, allowing
rationaleandconfidenceto be sent as a nestedintentobject (IssueUpdateIntent) instead of as flat fields. This is controlled by a new feature flag, enabling a smooth migration to the updated backend schema. The changes include the new feature flag, updates to the input struct, conditional logic for payload construction, and a comprehensive test.FeatureFlagIssueFieldsUseIntentto control use of nestedintentobject for rationale/confidence.Intentfield toIssueFieldCreateOrUpdateInputand defined newIssueUpdateIntentInputstruct.GranularSetIssueFieldsto conditionally send rationale/confidence as either flat fields or nested object based on the feature flag.MCP impact
Prompts tested (tool changes only)
Security / limits
Tool renaming
deprecated_tool_aliases.goNote: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.
Lint & tests
./script/lint./script/testDocs