Refactor three `pkg/workflow` largefunc hotspots into local helpers by Copilot · Pull Request #43195 · github/gh-aw

Copilot · 2026-07-03T13:21:30Z

This trims a small slice of the function-length backlog in pkg/workflow by removing three largefunc findings without changing behavior. The refactor stays local to the existing package and focuses on helper extraction around existing control flow.

Action resolver
- Extracts embedded-pin lookup from ResolveSHA into a dedicated helper.
- Keeps the existing resolution order intact: failed-run short-circuit, cache hit, embedded pin, then GitHub API fallback.
- Preserves the existing behavior that embedded pins are resolved in-memory and are not written back to the on-disk cache.
Antigravity tool mapping
- Splits bash tool expansion from computeAntigravityToolsCore into focused helpers.
- Isolates wildcard detection from per-command mapping.
- Keeps canonical run_shell_command(...) generation unchanged, including normalization of entries like jq *.
Input schema generation
- Extracts per-input schema construction from buildInputSchema.
- Separates metadata extraction (description, required) from property assembly.
- Preserves existing handling for number, boolean, choice, and fallback-to-string cases.
Targeted regression coverage
- Adds coverage for embedded action pin resolution staying out of cache persistence.
- Adds coverage for invalid choice.options shapes falling back to plain string properties.
- Adds coverage for non-string bash command entries being ignored during Antigravity tool expansion.

Example of the extracted ResolveSHA flow:

if sha, found := r.cache.GetByCacheKey(cacheKey); found {
	return sha, nil
}

if sha, found := r.resolveFromEmbeddedPins(repo, version); found {
	return sha, nil
}

return r.resolveFromGitHub(ctx, repo, version)

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions · 2026-07-03T13:32:09Z

Hey @copilot-swe-agent 👋 — thanks for picking up the lint-monster function-length backlog in pkg/workflow and pkg/cli! The PR is well-scoped and clearly tied to the tracking issue. A couple of things to address before it's reviewable:

Add actual code changes — the PR currently has 0 additions and 0 deletions. The remediation plan is solid, but the refactoring work (helper extraction, control-flow simplification) needs to land in the diff before reviewers can evaluate it.
Include or update tests — once the helpers are extracted, confirm that existing tests still pass and add targeted tests for any new helper functions that have non-trivial logic.
Validate with make golint-custom — the issue checklist asks for confirmation that the refactored functions no longer appear in the largefunc findings; include that output (or a summary of removed findings) in the PR description.

If you'd like a hand completing this, here's a ready-to-use prompt:

Complete the function-length refactoring for the first suggested slice from the lint-monster tracking issue (github/gh-aw#42880).

Slice to address:
- pkg/workflow/action_resolver.go (ResolveSHA, 67 lines)
- pkg/workflow/antigravity_tools.go
- pkg/workflow/build_input_schema.go

Steps:
1. Extract helpers to reduce each function below the lint threshold. Keep helpers in the same package; do not create shared abstractions unless clearly justified.
2. Preserve all existing behavior and tests.
3. Run `make golint-custom` and confirm the targeted functions no longer appear in the largefunc findings.
4. Update this PR description with the list of functions removed from the backlog and any recommended follow-up slices.

Generated by ✅ Contribution Check · 116.2 AIC · ⌖ 16 AIC · ⊞ 6.3K · ◷

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions · 2026-07-03T18:51:14Z

PR Triage

Field	Value
Category	refactor (function-length)
Risk	Medium
Score	30 (impact 12 + urgency 8 + quality 10)
Action	`defer`

Breakdown: Extracts 3 largefunc hotspots in pkg/workflow into local helpers. Draft. 186 add/108 del. No behavior change claimed but untested refactor in workflow core. Low urgency.

Next: Promote to ready when tests confirm no regressions; consider batching with other lint-monster refactors.

Generated by 🔧 PR Triage Agent · 86.6 AIC · ⌖ 10.9 AIC · ⊞ 5.5K · ◷

…ring

Copilot

Pull request overview

This pull request refactors three pkg/workflow “largefunc” hotspots by extracting local helper functions while aiming to preserve existing behavior, and adds targeted regression tests around the refactored flows.

Changes:

Extracted per-input schema construction into helpers for buildInputSchema.
Split Antigravity bash tool expansion into appendAntigravityBashTools plus a dedicated wildcard detector.
Extracted embedded action pin resolution from ActionResolver.ResolveSHA into resolveFromEmbeddedPins, and added regression coverage around cache non-persistence.

Show a summary per file

File	Description
pkg/workflow/build_input_schema.go	Extracts per-input schema building into helper functions.
pkg/workflow/build_input_schema_test.go	Adds coverage for invalid `choice.options` shape falling back to plain string schema.
pkg/workflow/antigravity_tools.go	Extracts bash tool mapping/wildcard detection into helpers.
pkg/workflow/antigravity_engine_test.go	Adds coverage for ignoring non-string bash command entries during tool expansion.
pkg/workflow/action_resolver.go	Extracts embedded-pin lookup into a dedicated resolver helper.
pkg/workflow/action_resolver_test.go	Adds regression coverage ensuring embedded pins do not write to the on-disk action cache.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 6/6 changed files
Comments generated: 2
Review effort level: Low

Copilot · 2026-07-04T04:06:04Z

+	inputType = "string"
+	inputDescription, inputRequired := getInputSchemaMetadata(inputName, inputDefMap, descriptionFn)
+	if typeStr, ok := inputDefMap["type"].(string); ok {


Fixed in the latest commit. Changed := to var inputDescription string + = assignment so inputRequired correctly assigns to the named return variable without shadowing.

gh-aw-bot · 2026-07-04T03:47:45Z

@copilot please run the pr-finisher skill, add and link the required ADR in the PR body, refresh the branch from main if needed, and rerun checks once updates are pushed.

Generated by 👨‍🍳 PR Sous Chef · 5.58 AIC · ⌖ 7.65 AIC · ⊞ 6.7K · ◷
_{Comment /souschef to run again}

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

…ionPinByRepo, add ADR, fix pre-existing lint/golden issues Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-07-04T04:06:19Z

@copilot please run the pr-finisher skill, add and link the required ADR in the PR body, refresh the branch from main if needed, and rerun checks once updates are pushed.

...

Done:

ADR added: docs/adr/43195-refactor-workflow-largefunc-hotspots.md — covers the three helper extractions, alternatives considered, and behavioral invariants preserved.
Review threads addressed: fixed named return shadowing in build_input_schema.go and switched to GetLatestActionPinByRepo() in the test.
Branch already up-to-date with main (merge commit 51a5887 was already present).
Pre-existing issues fixed: modernize lint in arc_dind_artifacts.go and stale WASM golden for the playwright-cli version bump — both came in via the main merge.
Local validation: make agent-report-progress passes cleanly.

CI needs a human re-trigger (close/reopen or workflow_dispatch) since agent pushes do not trigger workflows.

Initial plan

9e220ba

Copilot AI assigned Copilot and pelikhan Jul 3, 2026

Copilot AI linked an issue Jul 3, 2026 that may be closed by this pull request

[lint-monster] lint-monster: function-length refactoring backlog #42880

Open

10 tasks

Copilot started work on behalf of pelikhan July 3, 2026 13:21 View session

Refactor workflow largefunc slice

74f7dd2

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions Bot mentioned this pull request Jul 3, 2026

[Contribution Check Report] Contribution Check — 2026-07-03 #43068

Closed

Document extracted workflow helpers

885ec94

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Refactor shared function lengths in pkg/workflow and pkg/cli~~ Refactor three pkg/workflow largefunc hotspots into local helpers Jul 3, 2026

Copilot finished work on behalf of pelikhan July 3, 2026 13:35

Copilot AI requested a review from pelikhan July 3, 2026 13:35

github-actions Bot added pr-action:defer pr-agent:copilot-swe-agent pr-priority:low pr-risk:medium pr-type:refactor labels Jul 3, 2026

This was referenced Jul 3, 2026

[PR Triage Report] PR Triage Report — 2026-07-03 (Run #28677894072) #43257

Closed

[Outcome Report] Outcome Report — 2026-07-04 #43274

Open

[PR Triage Report] PR Triage Report — 2026-07-04 (Run #28689979672) #43275

Open

pelikhan marked this pull request as ready for review July 4, 2026 03:37

Copilot AI review requested due to automatic review settings July 4, 2026 03:37

Merge branch 'main' into copilot/lint-monster-function-length-refacto…

51a5887

…ring

Copilot started reviewing on behalf of pelikhan July 4, 2026 03:38 View session

Copilot AI reviewed Jul 4, 2026

View reviewed changes

Copilot started work on behalf of gh-aw-bot July 4, 2026 03:48 View session

Copilot AI and others added 2 commits July 4, 2026 03:53

Initial plan: address review feedback and add ADR

d81e73f

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Address review feedback: fix named return shadowing, use GetLatestAct…

72719f4

…ionPinByRepo, add ADR, fix pre-existing lint/golden issues Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot July 4, 2026 04:07

Copilot AI requested a review from gh-aw-bot July 4, 2026 04:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Refactor three `pkg/workflow` largefunc hotspots into local helpers#43195

Refactor three `pkg/workflow` largefunc hotspots into local helpers#43195
pelikhan with Copilot wants to merge 6 commits into
mainfrom
copilot/lint-monster-function-length-refactoring

Copilot AI commented Jul 3, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 4, 2026

Uh oh!

Uh oh!

gh-aw-bot commented Jul 4, 2026

Uh oh!

Copilot AI commented Jul 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Copilot AI commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

github-actions Bot commented Jul 3, 2026

PR Triage

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

Copilot AI Jul 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gh-aw-bot commented Jul 4, 2026

Uh oh!

Copilot AI commented Jul 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Jul 3, 2026 •

edited

Loading