Upgradeliquidjs 10.13 (#50845)

Peter Bengtsson · dependabot[bot] · gracepark · web-flow · commit c251f6d64e42 · 2024-06-12T19:00:10.000Z
Signed-off-by: dependabot[bot] &lt;support@github.com&gt;
Co-authored-by: dependabot[bot] &lt;49699333+dependabot[bot]@users.noreply.github.com&gt;
Co-authored-by: Grace Park &lt;gracepark@github.com&gt;
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -272,7 +272,7 @@
     "javascript-stringify": "^2.1.0",
     "js-cookie": "^3.0.1",
     "js-yaml": "^4.1.0",
-    "liquidjs": "^10.7.0",
+    "liquidjs": "^10.13.1",
     "lodash": "^4.17.21",
     "lodash-es": "^4.17.21",
     "lowdb": "7.0.1",
diff --git a/src/content-linter/lib/helpers/liquid-utils.js b/src/content-linter/lib/helpers/liquid-utils.js
@@ -2,9 +2,14 @@ import { Tokenizer } from 'liquidjs'
 
 const liquidTokenCache = new Map()
 
-export function getLiquidTokens(content) {
+export function getLiquidTokens(content, { noCache = false } = {}) {
   if (!content) return []
 
+  if (noCache) {
+    const tokenizer = new Tokenizer(content)
+    return tokenizer.readTopLevelTokens()
+  }
+
   if (liquidTokenCache.has(content)) {
     return liquidTokenCache.get(content)
   }
diff --git a/src/data-directory/scripts/find-orphaned-features/find.ts b/src/data-directory/scripts/find-orphaned-features/find.ts
@@ -223,7 +223,11 @@ function checkString(
   }: { page?: Page; filePath?: string; languageCode?: string; verbose?: boolean } = {},
 ) {
   try {
-    for (const token of getLiquidTokens(string)) {
+    // The reason for the `noCache: true` is that we're going to be sending
+    // a LOT of different strings in and the cache will fill up rapidly
+    // when testing every possible string in every possible language for
+    // every page.
+    for (const token of getLiquidTokens(string, { noCache: true })) {
       if (token.name === 'ifversion' || token.name === 'elsif') {
         for (const arg of token.args.split(/\s+/)) {
           if (IGNORE_ARGS.has(arg)) continue
diff --git a/src/languages/scripts/count-translation-corruptions.ts b/src/languages/scripts/count-translation-corruptions.ts
@@ -77,7 +77,8 @@ function run(languageCode: string, site: Site, englishReusables: Reusables) {
   const illegalTags = new Map<string, number>()
 
   function countError(error: TokenizationError, where: string) {
-    const errorString = (error as any).originalError.message as string
+    const originalError = (error as any).originalError
+    const errorString = originalError ? originalError.message : error.message
     if (errorString.includes('illegal tag syntax')) {
       const illegalTag = (error as any).token.content
       illegalTags.set(illegalTag, (illegalTags.get(illegalTag) || 0) + 1)
