update some rimrafs (#44665)

rachmari · web-flow · commit a791e5e5e6bf · 2024-05-07T22:27:31.000Z
diff --git a/src/codeql-cli/scripts/sync.js b/src/codeql-cli/scripts/sync.js
@@ -74,7 +74,7 @@ async function setupEnvironment() {
   }
 
   // refresh the temp directory
-  rimraf.sync(TEMP_DIRECTORY)
+  await rimraf(TEMP_DIRECTORY)
   await mkdirp(TEMP_DIRECTORY)
 }
 
diff --git a/src/ghes-releases/scripts/archive-version.js b/src/ghes-releases/scripts/archive-version.js
@@ -150,7 +150,7 @@ async function main() {
   }
 
   // remove temp directory
-  rimraf.sync(tmpArchivalDirectory)
+  await rimraf(tmpArchivalDirectory)
 
   const app = createApp()
   const server = http.createServer(app)
diff --git a/src/rest/scripts/update-files.js b/src/rest/scripts/update-files.js
@@ -72,7 +72,7 @@ main()
 async function main() {
   const pipelines = Array.isArray(output) ? output : [output]
   await validateInputParameters()
-  rimraf.sync(TEMP_OPENAPI_DIR)
+  await rimraf(TEMP_OPENAPI_DIR)
   await mkdirp(TEMP_OPENAPI_DIR)
 
   // If the source repo is github, this is the local development workflow
@@ -97,7 +97,7 @@ async function main() {
     await copyFile(file, path.join(TEMP_OPENAPI_DIR, baseName))
   }
 
-  rimraf.sync(TEMP_BUNDLED_OPENAPI_DIR)
+  await rimraf(TEMP_BUNDLED_OPENAPI_DIR)
   await normalizeDataVersionNames(TEMP_OPENAPI_DIR)
 
   // The REST_API_DESCRIPTION_ROOT repo contains all current and
@@ -107,12 +107,12 @@ async function main() {
     const derefDir = await readdir(TEMP_OPENAPI_DIR)
     const currentOpenApiVersions = Object.values(allVersions).map((elem) => elem.openApiVersionName)
 
-    derefDir.forEach((schema) => {
+    for (const schema of derefDir) {
       // if the schema does not start with a current version name, delete it
       if (!currentOpenApiVersions.find((version) => schema.startsWith(version))) {
-        rimraf.sync(path.join(TEMP_OPENAPI_DIR, schema))
+        await rimraf(path.join(TEMP_OPENAPI_DIR, schema))
       }
-    })
+    }
   }
   const derefFiles = await readdir(TEMP_OPENAPI_DIR)
   const { restSchemas, webhookSchemas } = await getOpenApiSchemaFiles(derefFiles)
@@ -175,7 +175,7 @@ async function getBundledFiles() {
   }
 
   // Create a tmp directory to store schema files generated from github/github
-  rimraf.sync(TEMP_OPENAPI_DIR)
+  await rimraf(TEMP_OPENAPI_DIR)
   await mkdirp(TEMP_BUNDLED_OPENAPI_DIR)
 
   console.log(

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ async function setupEnvironment() {`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`// refresh the temp directory`
`77`		`- rimraf.sync(TEMP_DIRECTORY)`
	`77`	`+ await rimraf(TEMP_DIRECTORY)`
`78`	`78`	`await mkdirp(TEMP_DIRECTORY)`
`79`	`79`	`}`
`80`	`80`
Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@ async function main() {`
`150`	`150`	`}`
`151`	`151`
`152`	`152`	`// remove temp directory`
`153`		`- rimraf.sync(tmpArchivalDirectory)`
	`153`	`+ await rimraf(tmpArchivalDirectory)`
`154`	`154`
`155`	`155`	`const app = createApp()`
`156`	`156`	`const server = http.createServer(app)`