Skip to content
This repository was archived by the owner on Nov 1, 2017. It is now read-only.

Commit 4d97f12

Browse files
committed
Add blog post about PRReviewComment event payload changes
1 parent 30cdcb6 commit 4d97f12

File tree

3 files changed

+26
-7
lines changed

3 files changed

+26
-7
lines changed

Rakefile

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,21 +39,26 @@ task :publish, [:no_commit_msg] => [:clean, :remove_output_dir] do |t, args|
3939
mesg = commit_message(args[:no_commit_msg])
4040
sh "nanoc compile"
4141

42+
# save precious files
43+
`git checkout gh-pages`
44+
tmpdir = Dir.mktmpdir
45+
FileUtils.cp_r("enterprise", tmpdir)
46+
FileUtils.cp("robots.txt", tmpdir)
47+
`git checkout master`
48+
4249
ENV['GIT_DIR'] = File.expand_path(`git rev-parse --git-dir`.chomp)
4350
ENV['RUBYOPT'] = nil
4451
old_sha = `git rev-parse refs/remotes/origin/gh-pages`.chomp
4552
Dir.chdir('output') do
4653
ENV['GIT_INDEX_FILE'] = gif = '/tmp/dev.gh.i'
4754
ENV['GIT_WORK_TREE'] = Dir.pwd
4855
File.unlink(gif) if File.file?(gif)
56+
# restore precious files
57+
FileUtils.cp_r(Dir.glob("#{tmpdir}/**/*"), ".")
4958
`git add -A`
5059
tsha = `git write-tree`.strip
5160
puts "Created tree #{tsha}"
52-
# Heroku runs git@1.7, we don't have the luxury of -m
53-
if ENV['IS_HEROKU']
54-
`echo #{mesg} > changelog`
55-
csha = `git commit-tree #{tsha} -p #{old_sha} < changelog`.strip
56-
elsif old_sha.size == 40
61+
if old_sha.size == 40
5762
csha = `git commit-tree #{tsha} -p #{old_sha} -m '#{mesg}'`.strip
5863
else
5964
csha = `git commit-tree #{tsha} -m '#{mesg}'`.strip
@@ -62,6 +67,6 @@ task :publish, [:no_commit_msg] => [:clean, :remove_output_dir] do |t, args|
6267
puts `git show #{csha} --stat`
6368
puts "Updating gh-pages from #{old_sha}"
6469
`git update-ref refs/heads/gh-pages #{csha}`
65-
`git push origin gh-pages`
70+
# `git push origin gh-pages`
6671
end
6772
end
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
---
2+
kind: change
3+
title: New attributes for PullRequestReviewComment events
4+
created_at: 2014-06-09
5+
author_name: jdpace
6+
---
7+
8+
We've enhanced the [PullRequestReviewComment events payloads][pr-review-comment-events] to include `action` and `pull_request` attributes. With the addition of the `pull_request` attribute, you now have immediate access to detailed information about the pull request without needing an additional API request.
9+
10+
If you have any questions or feedback, please [get in touch][contact].
11+
12+
[contact]: https://github.com/contact?form[subject]=PullRequestReviewComment+Event+Payloads
13+
[pr-review-comment-events]: https://developer.github.com/v3/activity/events/types/#pullrequestreviewcommentevent

layouts/guides.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@ <h2><a href="/v3/">API</a></h2>
2222
<div id="js-sidebar" class="sidebar-shell">
2323
<div class="sidebar-module">
2424
<ul>
25-
<li><h3><a href="/guides/getting-started/">Getting Started</a></h3></li>
25+
<li><h3><a href="/guides/">Overview</a></h3></li>
26+
<li><h3><a href="/guides/getting-started/">Getting started</a></h3></li>
2627
<li><h3><a href="/guides/basics-of-authentication/">Basics of authentication</a></h3></li>
2728
<li><h3><a href="/guides/rendering-data-as-graphs/">Rendering data as graphs</a></h3></li>
2829
<li><h3><a href="/guides/working-with-comments/">Working with comments</a></h3></li>

0 commit comments

Comments
 (0)