Harden documentation sample API guard test

Copilot · brunoborges · Copilot · commit 53fd8654efb4 · 2026-03-03T18:08:49.000Z
Co-authored-by: brunoborges &lt;129743+brunoborges@users.noreply.github.com&gt;
diff --git a/src/test/java/com/github/copilot/sdk/DocumentationSamplesTest.java b/src/test/java/com/github/copilot/sdk/DocumentationSamplesTest.java
@@ -7,33 +7,129 @@
 import java.nio.file.Path;
 import java.util.ArrayList;
 import java.util.List;
-import java.util.regex.Pattern;
 import java.util.stream.Stream;
 
 import org.junit.jupiter.api.Test;
 
 class DocumentationSamplesTest {
 
-    private static final Pattern CREATE_SESSION_WITHOUT_PERMISSION = Pattern
-            .compile("createSession\\(\\s*new SessionConfig\\(\\)(?!\\.setOnPermissionRequest\\()", Pattern.DOTALL);
-    private static final Pattern RESUME_CONFIG_WITHOUT_PERMISSION = Pattern.compile(
-            "new ResumeSessionConfig\\(\\)(?!\\.setOnPermissionRequest\\()", Pattern.DOTALL);
-    private static final Pattern REMOVED_RESUME_OVERLOAD = Pattern
-            .compile("resumeSession\\([^,\\n\\)]*\\)\\.get\\(\\)");
-
     @Test
     void docsAndJbangSamplesUseRequiredPermissionHandler() throws IOException {
         for (Path path : documentationFiles()) {
-            String content = Files.readString(path);
-            assertFalse(CREATE_SESSION_WITHOUT_PERMISSION.matcher(content).find(),
-                    () -> path + " contains createSession sample without setOnPermissionRequest");
-            assertFalse(RESUME_CONFIG_WITHOUT_PERMISSION.matcher(content).find(),
+            String content = stripStringsAndComments(Files.readString(path));
+            assertFalse(hasConfigWithoutPermissionHandler(content, "SessionConfig"),
+                    () -> path + " contains SessionConfig sample without setOnPermissionRequest");
+            assertFalse(hasConfigWithoutPermissionHandler(content, "ResumeSessionConfig"),
                     () -> path + " contains ResumeSessionConfig sample without setOnPermissionRequest");
-            assertFalse(REMOVED_RESUME_OVERLOAD.matcher(content).find(),
+            assertFalse(hasSingleArgumentResumeSessionCall(content),
                     () -> path + " contains removed resumeSession(String) overload");
         }
     }
 
+    private static boolean hasConfigWithoutPermissionHandler(String content, String configType) {
+        String constructor = "new " + configType + "()";
+        int fromIndex = 0;
+        while (true) {
+            int start = content.indexOf(constructor, fromIndex);
+            if (start < 0) {
+                return false;
+            }
+            int end = content.indexOf(';', start);
+            if (end < 0) {
+                end = content.length();
+            }
+            if (!content.substring(start, end).contains("setOnPermissionRequest(")) {
+                return true;
+            }
+            fromIndex = start + constructor.length();
+        }
+    }
+
+    private static boolean hasSingleArgumentResumeSessionCall(String content) {
+        int fromIndex = 0;
+        while (true) {
+            int callStart = content.indexOf("resumeSession(", fromIndex);
+            if (callStart < 0) {
+                return false;
+            }
+            int index = callStart + "resumeSession(".length();
+            int depth = 1;
+            int topLevelCommaCount = 0;
+            while (index < content.length() && depth > 0) {
+                char c = content.charAt(index);
+                if (c == '(') {
+                    depth++;
+                } else if (c == ')') {
+                    depth--;
+                } else if (c == ',' && depth == 1) {
+                    topLevelCommaCount++;
+                }
+                index++;
+            }
+
+            if (depth == 0 && topLevelCommaCount == 0) {
+                return true;
+            }
+            fromIndex = callStart + 1;
+        }
+    }
+
+    private static String stripStringsAndComments(String input) {
+        StringBuilder out = new StringBuilder(input.length());
+        int i = 0;
+        while (i < input.length()) {
+            char c = input.charAt(i);
+            if (c == '"' || c == '\'') {
+                char quote = c;
+                out.append(' ');
+                i++;
+                while (i < input.length()) {
+                    char current = input.charAt(i);
+                    out.append(' ');
+                    if (current == '\\') {
+                        i++;
+                        if (i < input.length()) {
+                            out.append(' ');
+                        }
+                    } else if (current == quote) {
+                        i++;
+                        break;
+                    }
+                    i++;
+                }
+                continue;
+            }
+            if (c == '/' && i + 1 < input.length()) {
+                char next = input.charAt(i + 1);
+                if (next == '/') {
+                    out.append(' ').append(' ');
+                    i += 2;
+                    while (i < input.length() && input.charAt(i) != '\n') {
+                        out.append(' ');
+                        i++;
+                    }
+                    continue;
+                }
+                if (next == '*') {
+                    out.append(' ').append(' ');
+                    i += 2;
+                    while (i + 1 < input.length() && !(input.charAt(i) == '*' && input.charAt(i + 1) == '/')) {
+                        out.append(' ');
+                        i++;
+                    }
+                    if (i + 1 < input.length()) {
+                        out.append(' ').append(' ');
+                        i += 2;
+                    }
+                    continue;
+                }
+            }
+            out.append(c);
+            i++;
+        }
+        return out.toString();
+    }
+
     private static List<Path> documentationFiles() throws IOException {
         Path root = Path.of("").toAbsolutePath();
         List<Path> files = new ArrayList<>();
