Java: Normalize java_version in integration test - #22308
Open
navntoft wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Redacts the environment-dependent JDK patch version to stabilize the Java Gradle buildless integration test.
Changes:
- Redacts
attributes.java_version. - Updates the expected diagnostics output.
Show a summary per file
| File | Description |
|---|---|
test.py |
Adds Java version redaction. |
diagnostics.expected |
Records the redacted value. |
Review details
Tip
Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
jketema
previously approved these changes
Aug 10, 2026
jketema
left a comment
Contributor
There was a problem hiding this comment.
Thanks. LGTM (assuming CI passed).
navntoft
force-pushed
the
navntoft/fix-gradle-buildless-test
branch
from
August 10, 2026 14:56
5ecc3ab to
82dfa2d
Compare
jketema
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
gradle-sample-without-wrapper-or-gradle-buildlessintegration test hardcodesjava_version: "11.0.31"indiagnostics.expected. This breaks when the CI runner updates JDK (now 11.0.32).The field was introduced in fefe01e (June 2026) which batch-added the new
java/extractor/summarydiagnostic to ~22 tests.Fix: redactjava_versionthe same wayjava_vendoralready is.Update: normalizing
java_versioninstead, see review.