Kotlin: Update tests to use new kotlin_2_3_20 fixture#22048
Open
jketema wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates a set of Kotlin integration tests to compile using a new Kotlin 2.3.20 compiler fixture, aligning test execution with the intended Kotlin toolchain selection rather than relying on a default kotlinc on PATH.
Changes:
- Remove
pytestimport /@pytest.mark.kotlin1usage in the updated tests. - Inject a
kotlinc_2_3_20fixture into affected tests and use it to runkotlinccommands. - Keep tests pinned to Kotlin language version 1.9 for compilation (where specified).
Show a summary per file
| File | Description |
|---|---|
| java/ql/integration-tests/kotlin/all-platforms/kotlin_java_lowering_wildcards/test.py | Switches Kotlin compilation to kotlinc_2_3_20 within a multi-step database creation command. |
| java/ql/integration-tests/kotlin/all-platforms/java-interface-redeclares-tostring/test.py | Uses kotlinc_2_3_20 for compiling the Kotlin user file. |
| java/ql/integration-tests/kotlin/all-platforms/file_classes/test.py | Uses kotlinc_2_3_20 for compiling Kotlin sources before/while creating the DB. |
| java/ql/integration-tests/kotlin/all-platforms/extractor_information_kotlin1/test.py | Uses kotlinc_2_3_20 for the extractor information test compilation. |
| java/ql/integration-tests/kotlin/all-platforms/external-property-overloads/test.py | Uses kotlinc_2_3_20 for both library and user compilation steps. |
| java/ql/integration-tests/kotlin/all-platforms/enhanced-nullability/test.py | Uses kotlinc_2_3_20 for Kotlin compilation in a mixed Java/Kotlin build. |
Copilot's findings
- Files reviewed: 6/6 changed files
- Comments generated: 1
Comment on lines
8
to
+11
| command=[ | ||
| "kotlinc kotlindefns.kt", | ||
| f"{kotlinc_2_3_20} kotlindefns.kt", | ||
| "javac JavaUser.java JavaDefns.java -cp .", | ||
| "kotlinc -language-version 1.9 -cp . kotlinuser.kt", | ||
| f"{kotlinc_2_3_20} -language-version 1.9 -cp . kotlinuser.kt", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.