Skip to content

JS: lower @precision of js/remote-property-injection#193

Merged
asger-semmle merged 1 commit into
masterfrom
unknown repository
Sep 14, 2018
Merged

JS: lower @precision of js/remote-property-injection#193
asger-semmle merged 1 commit into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Sep 13, 2018

Copy link
Copy Markdown

As seen in https://git.semmle.com/esben/dist-compare-reports/commit/cf6c864569e6ff9586cd48184acdceab22c12c28#commitcomment-4862 and https://git.semmle.com/gist/esben/1bc16ef80603298656c8e9592f9d32d5#gistcomment-77, the alerts from this query are rarely true positives. I think it should have @precision medium.

Assigning @max for his opinion.

@ghost ghost added the JS label Sep 13, 2018
@ghost ghost assigned xiemaisi Sep 13, 2018
@ghost ghost requested a review from xiemaisi September 13, 2018 19:52
@ghost ghost self-requested a review as a code owner September 13, 2018 19:52
xiemaisi
xiemaisi previously approved these changes Sep 14, 2018
@ghost

ghost commented Sep 14, 2018

Copy link
Copy Markdown
Author

Rebased to resolve conflicts

@asger-semmle asger-semmle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a post-rebase approval

@asger-semmle asger-semmle merged commit a3562aa into github:master Sep 14, 2018
aibaars pushed a commit that referenced this pull request Oct 14, 2021
Autogenerate QLDoc for `TreeSitter.qll`
smowton pushed a commit to smowton/codeql that referenced this pull request Jan 17, 2022
Add `ktLocalFunction` relation and tests for local and anonymous classes
MathiasVP pushed a commit to MathiasVP/ql that referenced this pull request Aug 10, 2025
Sync Main: More Bugs (Failed PR Creation)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants