C#: Remove unused PasswordInConfigurationFile.config#1475
Merged
Conversation
calumgrant
suggested changes
Jun 19, 2019
calumgrant
left a comment
Contributor
There was a problem hiding this comment.
There's also the file EmptyPasswordInConfigurationFile.config in the same directory which is similarly unused, so we should remove that as well to be consistent.
I also think the help for these queries could be improved a bit. There is no real documentation for how we decide what's a password or not. It could be helpful to actually include the example in the documentation, once it's been tidied up a bit.
calumgrant
approved these changes
Aug 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.