Skip to content

Commit aba008d

Browse files
owen-mcowen-mc
committed
Remove comments "// BAD: but flagged by cs/constant-condition"
1 parent 7b96f66 commit aba008d

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

‎csharp/ql/test/query-tests/CSI/CompareIdenticalValues/CompareIdenticalValues.cs‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public void M()
1717

1818
var x = "Abc";
1919
if (x == "Abc") ;
20-
var temp = x == x; // $ Alert[cs/constant-condition] // BAD: but flagged by cs/constant-condition
20+
var temp = x == x; // $ Alert[cs/constant-condition]
2121

2222
double d = double.NaN;
2323
if (d == d) ; // $ Alert[cs/comparison-of-identical-expressions] // !double.IsNan(d)
@@ -36,8 +36,8 @@ public void M()
3636
if (f < f) ; // $ Alert[cs/comparison-of-identical-expressions] // always false
3737

3838
int i = 0;
39-
if (i == i) ; // $ Alert[cs/constant-condition] // BAD: but flagged by cs/constant-condition
40-
if (i != i) ; // $ Alert[cs/constant-condition] // BAD: but flagged by cs/constant-condition
39+
if (i == i) ; // $ Alert[cs/constant-condition]
40+
if (i != i) ; // $ Alert[cs/constant-condition]
4141

4242
CompareIdenticalValues c = null;
4343
c.Prop.Equals(c.Prop); // $ Alert[cs/comparison-of-identical-expressions]
@@ -48,9 +48,9 @@ public void M()
4848
if (Bar == this.Bar) ; // $ Alert[cs/comparison-of-identical-expressions]
4949
Equals(this); // $ Alert[cs/comparison-of-identical-expressions]
5050

51-
if (1 + 1 == 2) ; // $ Alert[cs/constant-condition] // BAD: but flagged by cs/constant-condition
52-
if (1 + 1 == 3) ; // $ Alert[cs/constant-condition] // BAD: but flagged by cs/constant-condition
53-
if (0 == 1) ; // $ Alert[cs/constant-condition] // BAD: but flagged by cs/constant-condition
51+
if (1 + 1 == 2) ; // $ Alert[cs/constant-condition]
52+
if (1 + 1 == 3) ; // $ Alert[cs/constant-condition]
53+
if (0 == 1) ; // $ Alert[cs/constant-condition]
5454

5555
var a = new int[0];
5656
if (a[0] == a[0]) ; // $ Alert[cs/comparison-of-identical-expressions]

0 commit comments

Comments
 (0)