Minor formatting fixes

bananabr · bananabr · commit a2ad924376d5 · 2022-10-24T09:38:17.000-05:00
diff --git a/javascript/ql/src/experimental/Security/CWE-340/TokenBuiltFromUUID.qhelp b/javascript/ql/src/experimental/Security/CWE-340/TokenBuiltFromUUID.qhelp
@@ -34,7 +34,7 @@ Version four is the only UUID version expected to be randomly generated.
 
 <references>
 <li>UUID <a href="https://datatracker.ietf.org/doc/html/rfc4122">RFC</a>.</li>
-<li>Daniel Thatcher <i>In GUID We Trust<i> <a href="https://www.intruder.io/research/in-guid-we-trust">article</a>.</li>
+<li>Daniel Thatcher <i>In GUID We Trust</i> <a href="https://www.intruder.io/research/in-guid-we-trust">article</a>.</li>
 <li>UUID exploitation <a href="https://github.com/intruder-io/guidtool">tool</a>.</li>
 </references>
 </qhelp>
diff --git a/javascript/ql/src/experimental/Security/CWE-340/TokenBuiltFromUUID.ql b/javascript/ql/src/experimental/Security/CWE-340/TokenBuiltFromUUID.ql
@@ -43,14 +43,14 @@ class TokenAssignmentValueSink extends DataFlow::Node {
   }
 }
 
-class TokenBuiltFromUUIDConfig extends TaintTracking::Configuration {
-  TokenBuiltFromUUIDConfig() { this = "TokenBuiltFromUUIDConfig" }
+class TokenBuiltFromUuidConfig extends TaintTracking::Configuration {
+  TokenBuiltFromUuidConfig() { this = "TokenBuiltFromUuidConfig" }
 
   override predicate isSource(DataFlow::Node source) { source instanceof PredictableResultSource }
 
   override predicate isSink(DataFlow::Node sink) { sink instanceof TokenAssignmentValueSink }
 }
 
-from DataFlow::PathNode source, DataFlow::PathNode sink, TokenBuiltFromUUIDConfig config
+from DataFlow::PathNode source, DataFlow::PathNode sink, TokenBuiltFromUuidConfig config
 where config.hasFlowPath(source, sink)
 select sink.getNode(), source, sink, "Token built from $@.", source.getNode(), "predictable value"
diff --git a/python/ql/src/experimental/Security/CWE-340/TokenBuiltFromUUID.qhelp b/python/ql/src/experimental/Security/CWE-340/TokenBuiltFromUUID.qhelp
@@ -34,7 +34,7 @@ Version four is the only UUID version expected to be randomly generated.
 
 <references>
 <li>UUID <a href="https://datatracker.ietf.org/doc/html/rfc4122">RFC</a>.</li>
-<li>Daniel Thatcher <i>In GUID We Trust<i> <a href="https://www.intruder.io/research/in-guid-we-trust">article</a>.</li>
+<li>Daniel Thatcher <i>In GUID We Trust</i> <a href="https://www.intruder.io/research/in-guid-we-trust">article</a>.</li>
 <li>UUID exploitation <a href="https://github.com/intruder-io/guidtool">tool</a>.</li>
 </references>
 </qhelp>
diff --git a/python/ql/src/experimental/Security/CWE-340/TokenBuiltFromUUID.ql b/python/ql/src/experimental/Security/CWE-340/TokenBuiltFromUUID.ql
@@ -47,8 +47,8 @@ class TokenAssignmentValueSink extends DataFlow::Node {
   }
 }
 
-class TokenBuiltFromUUIDConfig extends TaintTracking::Configuration {
-  TokenBuiltFromUUIDConfig() { this = "TokenBuiltFromUUIDConfig" }
+class TokenBuiltFromUuidConfig extends TaintTracking::Configuration {
+  TokenBuiltFromUuidConfig() { this = "TokenBuiltFromUuidConfig" }
 
   override predicate isSource(DataFlow::Node source) { source instanceof PredictableResultSource }
 
@@ -64,6 +64,6 @@ class TokenBuiltFromUUIDConfig extends TaintTracking::Configuration {
   }
 }
 
-from DataFlow::PathNode source, DataFlow::PathNode sink, TokenBuiltFromUUIDConfig config
+from DataFlow::PathNode source, DataFlow::PathNode sink, TokenBuiltFromUuidConfig config
 where config.hasFlowPath(source, sink)
 select sink.getNode(), source, sink, "Token built from $@.", source.getNode(), "predictable value"

Original file line number	Diff line number	Diff line change
`@@ -43,14 +43,14 @@ class TokenAssignmentValueSink extends DataFlow::Node {`
`43`	`43`	`}`
`44`	`44`	`}`
`45`	`45`
`46`		`-class TokenBuiltFromUUIDConfig extends TaintTracking::Configuration {`
`47`		`- TokenBuiltFromUUIDConfig() { this = "TokenBuiltFromUUIDConfig" }`
	`46`	`+class TokenBuiltFromUuidConfig extends TaintTracking::Configuration {`
	`47`	`+ TokenBuiltFromUuidConfig() { this = "TokenBuiltFromUuidConfig" }`
`48`	`48`
`49`	`49`	`override predicate isSource(DataFlow::Node source) { source instanceof PredictableResultSource }`
`50`	`50`
`51`	`51`	`override predicate isSink(DataFlow::Node sink) { sink instanceof TokenAssignmentValueSink }`
`52`	`52`	`}`
`53`	`53`
`54`		`-from DataFlow::PathNode source, DataFlow::PathNode sink, TokenBuiltFromUUIDConfig config`
	`54`	`+from DataFlow::PathNode source, DataFlow::PathNode sink, TokenBuiltFromUuidConfig config`
`55`	`55`	`where config.hasFlowPath(source, sink)`
`56`	`56`	`select sink.getNode(), source, sink, "Token built from $@.", source.getNode(), "predictable value"`
Original file line number	Diff line number	Diff line change
`@@ -47,8 +47,8 @@ class TokenAssignmentValueSink extends DataFlow::Node {`
`47`	`47`	`}`
`48`	`48`	`}`
`49`	`49`
`50`		`-class TokenBuiltFromUUIDConfig extends TaintTracking::Configuration {`
`51`		`- TokenBuiltFromUUIDConfig() { this = "TokenBuiltFromUUIDConfig" }`
	`50`	`+class TokenBuiltFromUuidConfig extends TaintTracking::Configuration {`
	`51`	`+ TokenBuiltFromUuidConfig() { this = "TokenBuiltFromUuidConfig" }`
`52`	`52`
`53`	`53`	`override predicate isSource(DataFlow::Node source) { source instanceof PredictableResultSource }`
`54`	`54`
`@@ -64,6 +64,6 @@ class TokenBuiltFromUUIDConfig extends TaintTracking::Configuration {`
`64`	`64`	`}`
`65`	`65`	`}`
`66`	`66`
`67`		`-from DataFlow::PathNode source, DataFlow::PathNode sink, TokenBuiltFromUUIDConfig config`
	`67`	`+from DataFlow::PathNode source, DataFlow::PathNode sink, TokenBuiltFromUuidConfig config`
`68`	`68`	`where config.hasFlowPath(source, sink)`
`69`	`69`	`select sink.getNode(), source, sink, "Token built from $@.", source.getNode(), "predictable value"`