JS: make use of getUnderlyingValue

Esben Sparre Andreasen · Esben Sparre Andreasen · commit 7c7cd7c2135e · 2018-10-29T09:22:53.000+01:00
diff --git a/javascript/ql/src/semmle/javascript/Constants.qll b/javascript/ql/src/semmle/javascript/Constants.qll
@@ -127,10 +127,7 @@ module SyntacticConstants {
   class WrappedConstant extends SyntacticConstant {
 
     WrappedConstant() {
-      stripParens() instanceof SyntacticConstant or
-      this.(SeqExpr).getLastOperand() instanceof SyntacticConstant or
-      this.(TypeAssertion).getExpression() instanceof SyntacticConstant or
-      this.(Assignment).getRhs() instanceof SyntacticConstant
+      getUnderlyingValue() instanceof SyntacticConstant
     }
 
   }

Original file line number	Diff line number	Diff line change
`@@ -127,10 +127,7 @@ module SyntacticConstants {`
`127`	`127`	`class WrappedConstant extends SyntacticConstant {`
`128`	`128`
`129`	`129`	`WrappedConstant() {`
`130`		`- stripParens() instanceof SyntacticConstant or`
`131`		`- this.(SeqExpr).getLastOperand() instanceof SyntacticConstant or`
`132`		`- this.(TypeAssertion).getExpression() instanceof SyntacticConstant or`
`133`		`- this.(Assignment).getRhs() instanceof SyntacticConstant`
	`130`	`+ getUnderlyingValue() instanceof SyntacticConstant`
`134`	`131`	`}`
`135`	`132`
`136`	`133`	`}`