Java: Update the comments in SupportedExternalApis to include the neutral kind and add a sink neutral example.

michaelnebel · michaelnebel · commit 6deeb36a9785 · 2023-08-21T09:58:59.000+02:00
diff --git a/java/ql/test/query-tests/Telemetry/SupportedExternalApis/SupportedExternalApis.java b/java/ql/test/query-tests/Telemetry/SupportedExternalApis/SupportedExternalApis.java
@@ -17,14 +17,17 @@ public static void main(String[] args) throws Exception {
 		map.put("foo", new Object()); // supported summary
 		map.entrySet().iterator().next().getKey(); // nested class (Map.Entry), supported summaries (entrySet, iterator, next, getKey)
 
-		Duration d = java.time.Duration.ofMillis(1000); // supported neutral
+		Duration d = java.time.Duration.ofMillis(1000); // supported neutral summary
 
 		URL github = new URL("https://www.github.com/"); // supported summary
 		InputStream stream = github.openConnection().getInputStream(); // supported source (getInputStream), supported sink (openConnection)
 
 		new FileWriter(new File("foo")); // supported sink (FileWriter), supported summary (File)
 		new URL("http://foo").openStream(); // supported sink (openStream), supported summary (URL)
 
-		FileUtils.deleteDirectory(new File("foo")); // supported neutral (deleteDirectory), supported summary (File)
+		File file = new File("foo"); // supported summary (File)
+		FileUtils.deleteDirectory(file); // supported neutral summary (deleteDirectory)
+
+		file.compareTo(file); // supported neutral sink (compareTo)
 	}
 }
diff --git a/java/ql/test/query-tests/Telemetry/UnsupportedExternalAPIs/Test.java b/java/ql/test/query-tests/Telemetry/UnsupportedExternalAPIs/Test.java
@@ -11,15 +11,15 @@ public static void main(String[] args) {
 		Map<String, Object> map = new HashMap<>();
 		map.put("foo", new Object());
 
-		Duration d = java.time.Duration.ofMillis(1000); // supported as a neutral model
+		Duration d = java.time.Duration.ofMillis(1000); // supported as a neutral summary model
 
-		long l = "foo".length(); // supported as a neutral model
+		long l = "foo".length(); // supported as a neutral summary model
 
 		AtomicReference<String> ref = new AtomicReference<>(); // uninteresting (parameterless constructor)
 		ref.set("foo"); // supported as a summary model
 		ref.toString(); // not supported
 
-		String.class.isAssignableFrom(Object.class); // parameter with generic type, supported as a neutral model
+		String.class.isAssignableFrom(Object.class); // parameter with generic type, supported as a neutral summary model
 
 		System.out.println(d);
 		System.out.println(map);
