TokenBuiltFromUuid formatting

bananabr · bananabr · commit 5b080481aa93 · 2022-10-25T09:51:48.000-05:00
diff --git a/javascript/ql/src/experimental/Security/CWE-340/TokenBuiltFromUUID.ql b/javascript/ql/src/experimental/Security/CWE-340/TokenBuiltFromUUID.ql
@@ -30,8 +30,8 @@ class TokenAssignmentValueSink extends DataFlow::Node {
   TokenAssignmentValueSink() {
     exists(string name | name.toLowerCase().matches(["%token", "%code"]) |
       exists(PropWrite pw | this = pw.getRhs() | pw.getPropertyName().toLowerCase() = name)
-    or
-    exists(AssignExpr ae | this = ae.getRhs().flow() |
+      or
+      exists(AssignExpr ae | this = ae.getRhs().flow() |
         ae.getLhs().(VariableAccess).getVariable().getName().toLowerCase() = name
       )
     )
diff --git a/python/ql/src/experimental/Security/CWE-340/TokenBuiltFromUUID.ql b/python/ql/src/experimental/Security/CWE-340/TokenBuiltFromUUID.ql
@@ -20,10 +20,7 @@ import DataFlow::PathGraph
 class PredictableResultSource extends DataFlow::Node {
   PredictableResultSource() {
     exists(API::Node uuidCallRet |
-      uuidCallRet =
-        API::moduleImport("uuid")
-            .getMember(["uuid1", "uuid3", "uuid5"])
-            .getReturn()
+      uuidCallRet = API::moduleImport("uuid").getMember(["uuid1", "uuid3", "uuid5"]).getReturn()
     |
       this = uuidCallRet.asSource()
       or
@@ -36,7 +33,7 @@ class TokenAssignmentValueSink extends DataFlow::Node {
   TokenAssignmentValueSink() {
     exists(string name | name.toLowerCase().matches(["%token", "%code"]) |
       exists(DefinitionNode n | n.getValue() = this.asCfgNode() | name = n.(NameNode).getId())
-        or
+      or
       exists(DataFlow::AttrWrite aw | aw.getValue() = this | name = aw.getAttributeName())
     )
   }

Original file line number	Diff line number	Diff line change
`@@ -30,8 +30,8 @@ class TokenAssignmentValueSink extends DataFlow::Node {`
`30`	`30`	`TokenAssignmentValueSink() {`
`31`	`31`	`exists(string name \| name.toLowerCase().matches(["%token", "%code"]) \|`
`32`	`32`	`exists(PropWrite pw \| this = pw.getRhs() \| pw.getPropertyName().toLowerCase() = name)`
`33`		`- or`
`34`		`- exists(AssignExpr ae \| this = ae.getRhs().flow() \|`
	`33`	`+ or`
	`34`	`+ exists(AssignExpr ae \| this = ae.getRhs().flow() \|`
`35`	`35`	`ae.getLhs().(VariableAccess).getVariable().getName().toLowerCase() = name`
`36`	`36`	`)`
`37`	`37`	`)`