Python: Modernise Variables/Undefined.qll

RasmusWL · RasmusWL · commit 58bb16e5dda0 · 2019-12-20T15:05:49.000+01:00
diff --git a/python/ql/src/Variables/Undefined.qll b/python/ql/src/Variables/Undefined.qll
@@ -37,11 +37,11 @@ private predicate first_use(NameNode u, EssaVariable v) {
     )
 }
 
-/* Holds if `call` is a call of the form obj.method_name(...) and 
+/* Holds if `call` is a call of the form obj.method_name(...) and
  * there is a function called `method_name` that can exit the program.
  */
 private predicate maybe_call_to_exiting_function(CallNode call) {
-    exists(FunctionObject exits, string name |
+    exists(FunctionValue exits, string name |
         exits.neverReturns() and exits.getName() = name
         |
         call.getFunction().(NameNode).getId() = name or
@@ -119,5 +119,3 @@ class UninitializedConfig extends TaintTracking::Configuration {
     }
 
 }
-
-

Original file line number	Diff line number	Diff line change
`@@ -37,11 +37,11 @@ private predicate first_use(NameNode u, EssaVariable v) {`
`37`	`37`	`)`
`38`	`38`	`}`
`39`	`39`
`40`		-/* Holds if `call` is a call of the form obj.method_name(...) and
	`40`	+/* Holds if `call` is a call of the form obj.method_name(...) and
`41`	`41`	* there is a function called `method_name` that can exit the program.
`42`	`42`	`*/`
`43`	`43`	`private predicate maybe_call_to_exiting_function(CallNode call) {`
`44`		`- exists(FunctionObject exits, string name \|`
	`44`	`+ exists(FunctionValue exits, string name \|`
`45`	`45`	`exits.neverReturns() and exits.getName() = name`
`46`	`46`	`\|`
`47`	`47`	`call.getFunction().(NameNode).getId() = name or`
`@@ -119,5 +119,3 @@ class UninitializedConfig extends TaintTracking::Configuration {`
`119`	`119`	`}`
`120`	`120`
`121`	`121`	`}`
`122`		`-`
`123`		`-`