JavaScript: Replace --externs extractor flag with /** @externs */ comment.

Max Schaefer · Max Schaefer · commit 484837243580 · 2019-11-06T13:01:28.000Z
diff --git a/javascript/ql/test/library-tests/Externs/Point.js b/javascript/ql/test/library-tests/Externs/Point.js
@@ -17,4 +17,4 @@ Point.prototype['final'];
 /** @type {!Point} */
 var aPoint;
 
-//semmle-extractor-options: --externs
+/** @externs */
diff --git a/javascript/ql/test/query-tests/Declarations/ArgumentsRedefined/externs.js b/javascript/ql/test/query-tests/Declarations/ArgumentsRedefined/externs.js
@@ -1,3 +1,3 @@
 var arguments;
 
-//semmle-extractor-options: --externs
+/** @externs */
diff --git a/javascript/ql/test/query-tests/Declarations/DeadStoreOfGlobal/externs.js b/javascript/ql/test/query-tests/Declarations/DeadStoreOfGlobal/externs.js
@@ -38,4 +38,4 @@ function Worker(opt_arg0) {}
  */
 Worker.prototype.onmessage = function() {};
 
-//semmle-extractor-options: --externs
+/** @externs */
diff --git a/javascript/ql/test/query-tests/Declarations/DeadStoreOfProperty/externs.js b/javascript/ql/test/query-tests/Declarations/DeadStoreOfProperty/externs.js
@@ -40,4 +40,4 @@ function Element() {}
  */
 Element.prototype.clientTop;
 
-//semmle-extractor-options: --externs
+/** @externs */
diff --git a/javascript/ql/test/query-tests/Declarations/RedeclaredVariable/externs.js b/javascript/ql/test/query-tests/Declarations/RedeclaredVariable/externs.js
@@ -2,4 +2,4 @@
 var f = function() {};
 var f = function(x) {};
 
-//semmle-extractor-options: --externs
+/** @externs */
diff --git a/javascript/ql/test/query-tests/Declarations/TooManyParameters/externs.js b/javascript/ql/test/query-tests/Declarations/TooManyParameters/externs.js
@@ -1,4 +1,4 @@
 // OK: overly long parameter lists in external APIs aren't the fault of the externs definitions
 function f(a, b, c, d, e, f, g, h) {}
 
-//semmle-extractor-options: --externs
+/** @externs */
diff --git a/javascript/ql/test/query-tests/Declarations/UnusedParameter/externs.js b/javascript/ql/test/query-tests/Declarations/UnusedParameter/externs.js
@@ -1,3 +1,3 @@
 function String(str) {}
 
-//semmle-extractor-options: --externs
+/** @externs */
diff --git a/javascript/ql/test/query-tests/Expressions/ExprHasNoEffect/externs.js b/javascript/ql/test/query-tests/Expressions/ExprHasNoEffect/externs.js
@@ -53,4 +53,4 @@ function Error() {}
  */
 function SyntaxError() {}
 
-//semmle-extractor-options: --externs
+/** @externs */
diff --git a/javascript/ql/test/query-tests/Expressions/SelfAssignment/externs.js b/javascript/ql/test/query-tests/Expressions/SelfAssignment/externs.js
@@ -36,4 +36,4 @@ function Element() {}
 
 Element.prototype.innerHTML;
 
-// semmle-extractor-options: --externs
+/** @externs */
diff --git a/javascript/ql/test/query-tests/JSDoc/BadParamTag/externs.js b/javascript/ql/test/query-tests/JSDoc/BadParamTag/externs.js
@@ -3,4 +3,4 @@
  */
 function f(x) {}
 
-//semmle-extractor-options: --externs
+/** @externs */
diff --git a/javascript/ql/test/query-tests/LanguageFeatures/InconsistentNew/externs.js b/javascript/ql/test/query-tests/LanguageFeatures/InconsistentNew/externs.js
@@ -7,4 +7,4 @@ String.prototype.toString = function() {};
 function Array() {}
 Array.prototype.toString = function() {};
 
-//semmle-extractor-options: --externs
+/** @externs */
diff --git a/javascript/ql/test/query-tests/LanguageFeatures/SemicolonInsertion/SemicolonInsertion.expected b/javascript/ql/test/query-tests/LanguageFeatures/SemicolonInsertion/SemicolonInsertion.expected
@@ -1,4 +1,4 @@
 | export.js:5:8:5:17 | var x = 42 | Avoid automated semicolon insertion (95% of all statements in $@ have an explicit semicolon). | export.js:1:1:29:0 | <toplevel> | the enclosing script |
-| jscript.js:3:1:3:36 | window. ... ad() {} | Avoid automated semicolon insertion (95% of all statements in $@ have an explicit semicolon). | jscript.js:1:1:27:42 | <toplevel> | the enclosing script |
+| jscript.js:3:1:3:36 | window. ... ad() {} | Avoid automated semicolon insertion (95% of all statements in $@ have an explicit semicolon). | jscript.js:1:1:26:0 | <toplevel> | the enclosing script |
 | tst.js:5:1:5:3 | var a = ... : 2\\n  } | Avoid automated semicolon insertion (91% of all statements in $@ have an explicit semicolon). | tst.js:1:1:42:1 | functio ... oo();\\n} | the enclosing function |
 | tst.js:7:3:7:10 | return 1 | Avoid automated semicolon insertion (91% of all statements in $@ have an explicit semicolon). | tst.js:1:1:42:1 | functio ... oo();\\n} | the enclosing function |
diff --git a/javascript/ql/test/query-tests/LanguageFeatures/SpuriousArguments/externs.js b/javascript/ql/test/query-tests/LanguageFeatures/SpuriousArguments/externs.js
@@ -39,4 +39,4 @@ function Number() {}
 
 Number.parseFloat = function(num) {};
 
-//semmle-extractor-options: --externs
+/** @externs */
diff --git a/javascript/ql/test/query-tests/NodeJS/DubiousImport/DubiousImport.expected b/javascript/ql/test/query-tests/NodeJS/DubiousImport/DubiousImport.expected
@@ -1,5 +1,5 @@
 | a.js:1:11:1:28 | require('./b').foo | Module $@ does not export symbol foo. | b.js:1:1:5:21 | <toplevel> | b |
 | main.js:5:1:5:5 | b.foo | Module $@ does not export symbol foo. | b.js:1:1:5:21 | <toplevel> | b |
 | main.js:15:1:15:9 | fs.renmae | Module $@ does not export symbol renmae. | fs.js:1:1:15:0 | <toplevel> | fs |
-| main.js:23:1:23:5 | l.bar | Module $@ does not export symbol bar. | l.js:1:1:7:52 | <toplevel> | l |
+| main.js:23:1:23:5 | l.bar | Module $@ does not export symbol bar. | l.js:1:1:6:0 | <toplevel> | l |
 | multi_import.js:16:3:16:10 | mod2.bar | Module $@ does not export symbol bar. | b.js:1:1:5:21 | <toplevel> | b |
diff --git a/javascript/ql/test/query-tests/NodeJS/DubiousImport/externs.js b/javascript/ql/test/query-tests/NodeJS/DubiousImport/externs.js
@@ -615,4 +615,4 @@ Array.some = function(arr, callback, opt_context) {};
  */
 Array.isArray = function(arr) {};
 
-//semmle-extractor-options: --externs
+/** @externs */
diff --git a/javascript/ql/test/query-tests/NodeJS/DubiousImport/fs-monkeypatch.js b/javascript/ql/test/query-tests/NodeJS/DubiousImport/fs-monkeypatch.js
@@ -2,4 +2,4 @@ var fs = require('fs');
 
 fs.move = fs.rename;
 
-//semmle-extractor-options: --externs
+/** @externs */
diff --git a/javascript/ql/test/query-tests/NodeJS/DubiousImport/fs.js b/javascript/ql/test/query-tests/NodeJS/DubiousImport/fs.js
@@ -11,4 +11,4 @@ fs.rename;
 
 module.exports = fs;
 
-//semmle-extractor-options: --externs
+/** @externs */

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`var arguments;`
`2`	`2`
`3`		`-//semmle-extractor-options: --externs`
	`3`	`+/** @externs */`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`function String(str) {}`
`2`	`2`
`3`		`-//semmle-extractor-options: --externs`
	`3`	`+/** @externs */`
Original file line number	Diff line number	Diff line change
`@@ -36,4 +36,4 @@ function Element() {}`
`36`	`36`
`37`	`37`	`Element.prototype.innerHTML;`
`38`	`38`
`39`		`-// semmle-extractor-options: --externs`
	`39`	`+/** @externs */`