Python: Adjust InsecureRandomnessCustomizations.qll

RasmusWL · RasmusWL · commit 2e2cee06c36e · 2022-11-22T14:46:29.000+01:00
diff --git a/python/ql/src/experimental/semmle/python/security/InsecureRandomnessCustomizations.qll b/python/ql/src/experimental/semmle/python/security/InsecureRandomnessCustomizations.qll
@@ -59,12 +59,11 @@ module InsecureRandomness {
    */
   class RandomFnSink extends Sink {
     RandomFnSink() {
-      exists(DataFlowCallable randomFn |
-        randomFn
-            .getName()
+      exists(Function func |
+        func.getName()
             .regexpMatch("(?i).*(gen(erate)?|make|mk|create).*(nonce|salt|pepper|Password).*")
       |
-        this.getEnclosingCallable() = randomFn
+        this.asExpr().getScope() = func
       )
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -59,12 +59,11 @@ module InsecureRandomness {`
`59`	`59`	`*/`
`60`	`60`	`class RandomFnSink extends Sink {`
`61`	`61`	`RandomFnSink() {`
`62`		`- exists(DataFlowCallable randomFn \|`
`63`		`- randomFn`
`64`		`- .getName()`
	`62`	`+ exists(Function func \|`
	`63`	`+ func.getName()`
`65`	`64`	`.regexpMatch("(?i).(gen(erate)?\|make\|mk\|create).(nonce\|salt\|pepper\|Password).*")`
`66`	`65`	`\|`
`67`		`- this.getEnclosingCallable() = randomFn`
	`66`	`+ this.asExpr().getScope() = func`
`68`	`67`	`)`
`69`	`68`	`}`
`70`	`69`	`}`