JS: Parser: Remove direct this.strict assignment

RasmusWL · RasmusWL · commit 16e2ac898f5f · 2024-04-09T14:58:14.000+02:00
diff --git a/javascript/extractor/src/com/semmle/jcorn/Parser.java b/javascript/extractor/src/com/semmle/jcorn/Parser.java
@@ -3108,7 +3108,7 @@ protected BlockStatement parseBlock(boolean allowStrict) {
       if (stmt != null) body.add(stmt);
       if (first && allowStrict && this.isUseStrict(stmt)) {
         oldStrict = this.strict;
-        this.setStrict(this.strict = true);
+        this.setStrict(true);
       }
       first = false;
     }
diff --git a/javascript/extractor/tests/strictmode/output/trap/assignargs.js.trap b/javascript/extractor/tests/strictmode/output/trap/assignargs.js.trap
@@ -196,29 +196,5 @@ successor(#20045,#20048)
 successor(#20057,#20041)
 successor(#20038,#20037)
 successor(#20054,#20038)
-#20059=*
-js_parse_errors(#20059,#20001,"Error: Assigning to arguments in strict mode","  arguments = 42;
-")
-#20060=@"loc,{#10000},3,3,3,3"
-locations_default(#20060,#10000,3,3,3,3)
-hasLocation(#20059,#20060)
-#20061=*
-lines(#20061,#20001,"function f() {","
-")
-hasLocation(#20061,#20003)
-#20062=*
-lines(#20062,#20001,"  'use strict';","
-")
-hasLocation(#20062,#20005)
-indentation(#10000,2," ",2)
-#20063=*
-lines(#20063,#20001,"  arguments = 42;","
-")
-hasLocation(#20063,#20007)
-indentation(#10000,3," ",2)
-#20064=*
-lines(#20064,#20001,"}","")
-hasLocation(#20064,#20009)
-numlines(#20001,4,0,0)
 numlines(#10000,4,4,0)
 filetype(#10000,"javascript")

Original file line number	Diff line number	Diff line change
`@@ -3108,7 +3108,7 @@ protected BlockStatement parseBlock(boolean allowStrict) {`
`3108`	`3108`	`if (stmt != null) body.add(stmt);`
`3109`	`3109`	`if (first && allowStrict && this.isUseStrict(stmt)) {`
`3110`	`3110`	`oldStrict = this.strict;`
`3111`		`- this.setStrict(this.strict = true);`
	`3111`	`+ this.setStrict(true);`
`3112`	`3112`	`}`
`3113`	`3113`	`first = false;`
`3114`	`3114`	`}`