Skip to content

Commit 0509228

Browse files
committed
Python: Make ModelUsage test language agnostic
1 parent 87eff7f commit 0509228

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

python/ql/test/library-tests/modules/usage/ModuleUsage.expected

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
| file://:0:0:0:0 | Module builtins | isUsedAsModule |
21
| file://:0:0:0:0 | Module sys | isUsedAsModule |
32
| imported.py:0:0:0:0 | Module imported | isUsedAsModule |
43
| main.py:0:0:0:0 | Module main | isUsedAsScript |

python/ql/test/library-tests/modules/usage/ModuleUsage.ql

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,15 @@ import python
22

33
from ModuleValue mv, string usage
44
where
5-
mv.isUsedAsModule() and usage = "isUsedAsModule"
6-
or
7-
mv.isUsedAsScript() and usage = "isUsedAsScript"
8-
or
9-
not mv.isUsedAsModule() and
10-
not mv.isUsedAsScript() and
11-
usage = "<UNKNOWN>"
5+
// builtin module has different name in Python 2 and 3
6+
not mv = Module::builtinModule() and
7+
(
8+
mv.isUsedAsModule() and usage = "isUsedAsModule"
9+
or
10+
mv.isUsedAsScript() and usage = "isUsedAsScript"
11+
or
12+
not mv.isUsedAsModule() and
13+
not mv.isUsedAsScript() and
14+
usage = "<UNKNOWN>"
15+
)
1216
select mv, usage

0 commit comments

Comments
 (0)