Uses hard-coded list of scans

lindseywild · lindseywild · commit effdb308fae6 · 2026-03-23T20:05:34.000Z
diff --git a/.github/actions/find/src/pluginManager.ts b/.github/actions/find/src/pluginManager.ts
@@ -20,6 +20,10 @@ type Plugin = {
   default: (options: PluginDefaultParams) => Promise<void>
 }
 
+// Built-in plugin names shipped with the scanner.
+// Used to skip duplicates when loading custom plugins.
+const BUILT_IN_PLUGINS = ['reflow-scan']
+
 const plugins: Plugin[] = []
 let pluginsLoaded = false
 
@@ -75,25 +79,29 @@ export async function loadCustomPlugins() {
     return
   }
 
-  await loadPluginsFromPath({pluginsPath})
+  await loadPluginsFromPath({pluginsPath, skipBuiltInPlugins: BUILT_IN_PLUGINS})
 }
 
 // exported for mocking/testing. not for actual use
-export async function loadPluginsFromPath({pluginsPath}: {pluginsPath: string}) {
+export async function loadPluginsFromPath({
+  pluginsPath,
+  skipBuiltInPlugins,
+}: {
+  pluginsPath: string
+  skipBuiltInPlugins?: string[]
+}) {
   try {
     const res = fs.readdirSync(pluginsPath)
     for (const pluginFolder of res) {
       const pluginFolderPath = path.join(pluginsPath, pluginFolder)
 
       if (fs.existsSync(pluginFolderPath) && fs.lstatSync(pluginFolderPath).isDirectory()) {
-        core.info(`Found plugin: ${pluginFolder}`)
-        const plugin = await dynamicImport(path.join(pluginsPath, pluginFolder, 'index.js'))
-        // Prevents a plugin from running twice
-        if (plugins.some(p => p.name === plugin.name)) {
-          core.info(`Skipping duplicate plugin: ${plugin.name}`)
+        if (skipBuiltInPlugins?.includes(pluginFolder)) {
+          core.info(`Skipping built-in plugin: ${pluginFolder}`)
           continue
         }
-        plugins.push(plugin)
+        core.info(`Found plugin: ${pluginFolder}`)
+        plugins.push(await dynamicImport(path.join(pluginsPath, pluginFolder, 'index.js')))
       }
     }
   } catch (e) {
diff --git a/.github/actions/find/tests/pluginManager.test.ts b/.github/actions/find/tests/pluginManager.test.ts
@@ -67,7 +67,7 @@ describe('loadPlugins', () => {
     })
   })
 
-  describe('when built-in and custom plugins share the same name', () => {
+  describe('when a custom plugin folder matches a built-in plugin name', () => {
     beforeEach(() => {
       // @ts-expect-error - we don't need the full fs readdirsync
       // method signature here
@@ -79,13 +79,14 @@ describe('loadPlugins', () => {
       })
     })
 
-    it('skips the duplicate and only loads the plugin once', async () => {
+    it('skips the built-in name in custom plugins and only loads it once', async () => {
       pluginManager.clearCache()
       const infoSpy = vi.spyOn(core, 'info').mockImplementation(() => {})
       const plugins = await pluginManager.loadPlugins()
+      // Built-in loads it, custom skips the folder by name
       expect(plugins.length).toBe(1)
       expect(plugins[0].name).toBe('reflow-scan')
-      expect(infoSpy).toHaveBeenCalledWith('Skipping duplicate plugin: reflow-scan')
+      expect(infoSpy).toHaveBeenCalledWith('Skipping built-in plugin: reflow-scan')
     })
   })
 })
diff --git a/README.md b/README.md
@@ -126,7 +126,7 @@ Trigger the workflow manually or automatically based on your configuration. The
 | `include_screenshots`     | No       | Whether to capture screenshots of scanned pages and include links to them in filed issues. Screenshots are stored on the `gh-cache` branch of the repository running the workflow. Default: `false` | `true`                                                      |
 | `reduced_motion`          | No       | Playwright `reducedMotion` setting for scan contexts. Allowed values: `reduce`, `no-preference`                                                                                                     | `reduce`                                                    |
 | `color_scheme`            | No       | Playwright `colorScheme` setting for scan contexts. Allowed values: `light`, `dark`, `no-preference`                                                                                                | `dark`                                                      |
-| `scans`                   | No       | An array of scans (or plugins) to be performed. If not provided, only Axe will be performed.                                                                                                        | `'["axe", "reflow-scan", ...other plugins]'`                                 |
+| `scans`                   | No       | An array of scans (or plugins) to be performed. If not provided, only Axe will be performed.                                                                        | `'["axe", "reflow-scan"]'`                                 |
 
 ---
 
