Merge pull request ipython#2903 from Carreau/toggle-line-number

Carreau · Carreau · commit 48c19e7b78e2 · 2013-02-16T07:20:55.000-08:00
Specify toggle value on cell line number
diff --git a/IPython/frontend/html/notebook/static/js/cell.js b/IPython/frontend/html/notebook/static/js/cell.js
@@ -239,17 +239,24 @@ var IPython = (function (IPython) {
         }
     };
 
+    /**
+     * Show/Hide CodeMirror LineNumber
+     * @method show_line_numbers
+     *
+     * @param value {Bool}  show (true), or hide (false) the line number in CodeMirror
+     **/
+    Cell.prototype.show_line_numbers = function (value) {
+        this.code_mirror.setOption('lineNumbers', value);
+        this.code_mirror.refresh();
+    };
+
     /**
      * Toggle  CodeMirror LineNumber
      * @method toggle_line_numbers
      **/
     Cell.prototype.toggle_line_numbers = function () {
-        if (this.code_mirror.getOption('lineNumbers') == false) {
-            this.code_mirror.setOption('lineNumbers', true);
-        } else {
-            this.code_mirror.setOption('lineNumbers', false);
-        }
-        this.code_mirror.refresh();
+        var val = this.code_mirror.getOption('lineNumbers');
+        this.show_line_numbers(!val);
     };
 
     /**
diff --git a/IPython/frontend/html/notebook/static/js/toolbar.js b/IPython/frontend/html/notebook/static/js/toolbar.js
@@ -40,7 +40,7 @@ var IPython = (function (IPython) {
      *          {
      *            label:'my button',
      *            icon:'ui-icon-disk',
-     *            callback:function(){alert('hoho'),
+     *            callback:function(){alert('hoho')},
      *            id : 'my_button_id',    // this is optional
      *          },
      *          {
