Fix console warning in LegacyImmutableObject

miorel · zpao · commit 335e91df7146 · 2014-08-29T14:32:50.000-07:00
It does check `hasOwnProperty`, but *after* accessing the field and therefore triggering enumerable getters in modified prototypes.
diff --git a/src/utils/LegacyImmutableObject.js b/src/utils/LegacyImmutableObject.js
@@ -81,9 +81,11 @@ if (__DEV__) {
     }
     Object.freeze(object); // First freeze the object.
     for (var prop in object) {
-      var field = object[prop];
-      if (object.hasOwnProperty(prop) && shouldRecurseFreeze(field)) {
-        deepFreeze(field);
+      if (object.hasOwnProperty(prop)) {
+        var field = object[prop];
+        if (shouldRecurseFreeze(field)) {
+          deepFreeze(field);
+        }
       }
     }
   };

Original file line number	Diff line number	Diff line change
`@@ -81,9 +81,11 @@ if (__DEV__) {`
`81`	`81`	`}`
`82`	`82`	`Object.freeze(object); // First freeze the object.`
`83`	`83`	`for (var prop in object) {`
`84`		`- var field = object[prop];`
`85`		`- if (object.hasOwnProperty(prop) && shouldRecurseFreeze(field)) {`
`86`		`- deepFreeze(field);`
	`84`	`+ if (object.hasOwnProperty(prop)) {`
	`85`	`+ var field = object[prop];`
	`86`	`+ if (shouldRecurseFreeze(field)) {`
	`87`	`+ deepFreeze(field);`
	`88`	`+ }`
`87`	`89`	`}`
`88`	`90`	`}`
`89`	`91`	`};`