Tidy up static analysis targets and add analyze target.

skeeto · skeeto · commit 3a1c5cf413e7 · 2012-05-04T23:34:35.000-04:00
diff --git a/build.xml b/build.xml
@@ -114,15 +114,6 @@
     </apply>
   </target>
 
-  <target name="check" depends="resolve">
-    <taskdef resource="checkstyletask.properties"
-             classpathref="analysis.classpath"/>
-    <checkstyle config="checkstyle.xml">
-      <fileset dir="${src.dir}" includes="**/*.java"/>
-      <classpath path="${build.dir}/classes"/>
-    </checkstyle>
-  </target>
-
   <target name="tags" description="Generate a TAGS file for your editor.">
     <delete file="TAGS"/>
     <apply executable="etags">
@@ -132,6 +123,15 @@
     </apply>
   </target>
 
+  <target name="check" depends="resolve" description="Run Checkstyle.">
+    <taskdef resource="checkstyletask.properties"
+             classpathref="analysis.classpath"/>
+    <checkstyle config="checkstyle.xml">
+      <fileset dir="${src.dir}" includes="**/*.java"/>
+      <classpath path="${build.dir}/classes"/>
+    </checkstyle>
+  </target>
+
   <target name="findbugs" depends="compile" description="Run FindBugs.">
     <taskdef classname="edu.umd.cs.findbugs.anttask.FindBugsTask"
              name="findbugs" classpathref="analysis.classpath"/>
@@ -142,7 +142,7 @@
     </findbugs>
   </target>
 
-  <target name="pmd" depends="resolve">
+  <target name="pmd" depends="resolve" description="Run PMD on the code.">
     <taskdef name="pmd" classname="net.sourceforge.pmd.ant.PMDTask"
              classpathref="analysis.classpath"/>
     <pmd>
@@ -154,6 +154,9 @@
     </pmd>
   </target>
 
+  <target name="analyze" depends="check,pmd,findbugs"
+          description="Run all static analysis tools."/>
+
   <!-- Unit testing (JUnit) -->
 
   <target name="test-compile" depends="compile">
