Merge pull request OtterMind#1182 from openai0229/issue#1135

Chat2DB-Pro · web-flow · commit cb0b6149253b · 2024-02-26T10:28:30.000+08:00
transaction support
diff --git a/chat2db-server/chat2db-plugins/chat2db-mysql/src/main/java/ai/chat2db/plugin/mysql/MysqlDBManage.java b/chat2db-server/chat2db-plugins/chat2db-mysql/src/main/java/ai/chat2db/plugin/mysql/MysqlDBManage.java
@@ -11,11 +11,18 @@
 
 public class MysqlDBManage extends DefaultDBManage implements DBManage {
     @Override
-    public void updateProcedure(Connection connection, String databaseName, String schemaName, Procedure procedure) {
-        String sql = "DROP PROCEDURE " + procedure.getProcedureName();
-        SQLExecutor.getInstance().execute(connection, sql, resultSet -> {});
-        String procedureBody = procedure.getProcedureBody();
-        SQLExecutor.getInstance().execute(connection, procedureBody, resultSet -> {});
+    public void updateProcedure(Connection connection, String databaseName, String schemaName, Procedure procedure) throws SQLException {
+        try {
+            connection.setAutoCommit(false);
+            String sql = "DROP PROCEDURE " + procedure.getProcedureName();
+            SQLExecutor.getInstance().execute(connection, sql, resultSet -> {});
+            String procedureBody = procedure.getProcedureBody();
+            SQLExecutor.getInstance().execute(connection, procedureBody, resultSet -> {});
+            connection.commit();
+        } catch (Exception e) {
+            connection.rollback();
+            throw new RuntimeException(e);
+        }
 
     }
 
diff --git a/chat2db-server/chat2db-spi/src/main/java/ai/chat2db/spi/DBManage.java b/chat2db-server/chat2db-spi/src/main/java/ai/chat2db/spi/DBManage.java
@@ -7,6 +7,7 @@
 import jakarta.validation.constraints.NotNull;
 
 import java.sql.Connection;
+import java.sql.SQLException;
 
 /**
  * @author jipengfei
@@ -119,5 +120,5 @@ void dropProcedure(Connection connection, @NotEmpty String databaseName, String
      * @param schemaName
      * @param procedure
      */
-    void updateProcedure(Connection connection, @NotEmpty String databaseName, String schemaName, @NotNull Procedure procedure);
+    void updateProcedure(Connection connection, @NotEmpty String databaseName, String schemaName, @NotNull Procedure procedure) throws SQLException;
 }
diff --git a/chat2db-server/chat2db-spi/src/main/java/ai/chat2db/spi/jdbc/DefaultDBManage.java b/chat2db-server/chat2db-spi/src/main/java/ai/chat2db/spi/jdbc/DefaultDBManage.java
@@ -135,7 +135,7 @@ public void dropProcedure(Connection connection, String databaseName, String sch
     }
 
     @Override
-    public void updateProcedure(Connection connection, String databaseName, String schemaName, Procedure procedure) {
+    public void updateProcedure(Connection connection, String databaseName, String schemaName, Procedure procedure) throws SQLException {
 
     }
 

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ public void dropProcedure(Connection connection, String databaseName, String sch`
`135`	`135`	`}`
`136`	`136`
`137`	`137`	`@Override`
`138`		`- public void updateProcedure(Connection connection, String databaseName, String schemaName, Procedure procedure) {`
	`138`	`+ public void updateProcedure(Connection connection, String databaseName, String schemaName, Procedure procedure) throws SQLException {`
`139`	`139`
`140`	`140`	`}`
`141`	`141`