Skip to content

Commit c654fae

Browse files
authored
Merge pull request OtterMind#1183 from openai0229/issue#1135
complete exception throwing
2 parents 4682224 + bc85aba commit c654fae

3 files changed

Lines changed: 9 additions & 3 deletions

File tree

  • chat2db-server

chat2db-server/chat2db-server-domain/chat2db-server-domain-api/src/main/java/ai/chat2db/server/domain/api/service/ProcedureService.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
import ai.chat2db.spi.model.Procedure;
77
import jakarta.validation.constraints.NotEmpty;
88

9+
import java.sql.SQLException;
10+
911
public interface ProcedureService {
1012

1113
/**
@@ -31,5 +33,5 @@ public interface ProcedureService {
3133
* @param procedure
3234
* @return
3335
*/
34-
ActionResult update(String databaseName, String schemaName, Procedure procedure);
36+
ActionResult update(String databaseName, String schemaName, Procedure procedure) throws SQLException;
3537
}

chat2db-server/chat2db-server-domain/chat2db-server-domain-core/src/main/java/ai/chat2db/server/domain/core/impl/ProcedureServiceImpl.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
import ai.chat2db.spi.sql.Chat2DBContext;
99
import org.springframework.stereotype.Service;
1010

11+
import java.sql.SQLException;
12+
1113
@Service
1214
public class ProcedureServiceImpl implements ProcedureService {
1315

@@ -21,7 +23,7 @@ public DataResult<Procedure> detail(String databaseName, String schemaName, Stri
2123
return DataResult.of(Chat2DBContext.getMetaData().procedure(Chat2DBContext.getConnection(), databaseName, schemaName, procedureName));
2224
}
2325
@Override
24-
public ActionResult update(String databaseName, String schemaName, Procedure procedure) {
26+
public ActionResult update(String databaseName, String schemaName, Procedure procedure) throws SQLException {
2527
Chat2DBContext.getDBManage().updateProcedure(Chat2DBContext.getConnection(), databaseName, schemaName, procedure);
2628
return ActionResult.isSuccess();
2729
}

chat2db-server/chat2db-server-web/chat2db-server-web-api/src/main/java/ai/chat2db/server/web/api/controller/rdb/ProcedureController.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515
import org.springframework.beans.factory.annotation.Autowired;
1616
import org.springframework.web.bind.annotation.*;
1717

18+
import java.sql.SQLException;
19+
1820
@ConnectionInfoAspect
1921
@RequestMapping("/api/rdb/procedure")
2022
@RestController
@@ -39,7 +41,7 @@ public DataResult<Procedure> detail(@Valid ProcedureDetailRequest request) {
3941
}
4042

4143
@PostMapping("/update")
42-
public ActionResult update(@Valid @RequestBody ProcedureUpdateRequest request) {
44+
public ActionResult update(@Valid @RequestBody ProcedureUpdateRequest request) throws SQLException {
4345
Procedure procedure = procedureConverter.request2param(request);
4446
return procedureService.update(request.getDatabaseName(), request.getSchemaName(), procedure);
4547
}

0 commit comments

Comments
 (0)