Welcome to GitGitGadget

Hi @liginity, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that your Pull Request has a good description, as it will be used as cover letter.

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

• the lines should not exceed 76 columns,
• the first line should be like a header and typically start with a prefix like "tests:" or "revisions:" to state which subsystem the change is about, and
• the commit messages' body should be describing the "why?" of the change.
• Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a comment to your PR of the form /allow. A good way to find other contributors is to locate recent pull requests where someone has been /allowed:

• Search: is:pr is:open "/allow"

Both the person who commented /allow and the PR author are able to /allow you.

An alternative is the channel #git-devel on the Libera Chat IRC network:

<newcontributor> I've just created my first PR, could someone please /allow me? https://github.com/gitgitgadget/git/pull/12345
<veteran> newcontributor: it is done
<newcontributor> thanks!

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

If you want to see what email(s) would be sent for a /submit request, add a PR comment /preview to have the email(s) sent to you. You must have a public GitHub email address for this.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions (while the comments and suggestions will be mirrored into the PR by GitGitGadget, you will still want to reply via mail).

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox from the Git mailing list archive (click the (raw) link), then import it into your mail program. If you use GMail, you can do this via:

curl -g --user "<EMailAddress>:<Password>" \
    --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

To iterate on your change, i.e. send a revised patch or patch series, you will first want to (force-)push to the same branch. You probably also want to modify your Pull Request description (or title). It is a good idea to summarize the revision by adding something like this to the cover letter (read: by editing the first comment on the PR, i.e. the PR description):

Changes since v1:
- Fixed a typo in the commit message (found by ...)
- Added a code comment to ... as suggested by ...
...

To send a new iteration, just add another PR comment with the contents: /submit.

Need help?

New contributors who want advice are encouraged to join git-mentoring@googlegroups.com, where volunteers who regularly contribute to Git are willing to answer newbie questions, give advice, or otherwise provide mentoring to interested contributors. You must join in order to post or view messages, but anyone can join.

You may also be able to find help in real time in the developer IRC channel, #git-devel on Libera Chat. Remember that IRC does not support offline messaging, so if you send someone a private message and log out, they cannot respond to you. The scrollback of #git-devel is archived, though.

Invalid author email in 802e1e9: "37213504+liginity@users.noreply.github.com"

/allow

User liginity is now allowed to use GitGitGadget.

WARNING: liginity has no public email address set on GitHub

Invalid author email in 802e1e9: "37213504+liginity@users.noreply.github.com"

Please fix: The Git project asks you:

Also notice that a real name is used in the Signed-off-by trailer. Please don’t hide your real name.

(which includes your real email address so you can be contacted regarding feedback.)

Well, sorry for my late response.

I have changed my github email setting and made my email public after I made the pull request, but I don't know whether gitgitgadget recognizes this.

How should I continue? Could I just post a comment with "/submit" to send the pull request?

I have changed my github email setting and made my email public after I made the pull request, but I don't know whether gitgitgadget recognizes this.

Oh, but I was talking about the email address recorded in the commit... Something like git config --global user.email "<address>" && git commit --amend --reset-author -s, removing the bogus "Signed-off-by" footer (if any), and force-pushing should fix this.

How should I continue? Could I just post a comment with "/submit" to send the pull request?

Whenever in doubt, try /preview first.

/preview

Preview email sent as pull.1207.git.git.1643791924402.gitgitgadget@gmail.com

I have fixed the commit author information and previewed it. I would submit it now.

/submit

Submitted as pull.1207.git.git.1643792450866.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-git-1207/liginity/patch-mktree-documentation-v1

To fetch this version to local tag pr-git-1207/liginity/patch-mktree-documentation-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-git-1207/liginity/patch-mktree-documentation-v1

On the Git mailing list, Ævar Arnfjörð Bjarmason wrote (reply to this):

On Wed, Feb 02 2022, lgl via GitGitGadget wrote:

> From: liginity <liginity@outlook.com>
>
> fix a typo: change "as" to "a".

Looks good, for what it's worth that typo was introduced in f1cf2d8b146
(mktree --batch: build more than one tree object, 2009-05-14)! So a very
old one.

User Ævar Arnfjörð Bjarmason <avarab@gmail.com> has been added to the cc: list.

On the Git mailing list, Junio C Hamano wrote (reply to this):

"lgl via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: liginity <liginity@outlook.com>
>
> fix a typo: change "as" to "a".
>  --batch::
>  	Allow building of more than one tree object before exiting.  Each
> -	tree is separated by as single blank line. The final new-line is
> +	tree is separated by a single blank line. The final new-line is

Makes sense; will queue.

Thanks.

On the Git mailing list, Junio C Hamano wrote (reply to this):

Junio C Hamano <gitster@pobox.com> writes:

> "lgl via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>> From: liginity <liginity@outlook.com>

No need to resend only to fix it this time, but for future
reference, please make sure your user.name (and user.email) is set
up so that they match the author identity on the Signed-off-by line.

I'll also fix this line to ...

>>    Signed-off-by: Liginity Lee liginity@outlook.com

... read

    Signed-off-by: Liginity Lee <liginity@outlook.com>

This branch is now known as ll/doc-mktree-typofix.

This patch series was integrated into seen via e5af02a.

This patch series was integrated into seen via 99bd659.

There was a status update in the "New Topics" section about the branch ll/doc-mktree-typofix on the Git mailing list:

Typofix.

Will merge to 'next'.
source: <pull.1207.git.git.1643792450866.gitgitgadget@gmail.com>

This patch series was integrated into seen via ba77e5f.

This patch series was integrated into seen via 1fcae99.

This patch series was integrated into seen via 8107544.

This patch series was integrated into seen via f13715e.

This patch series was integrated into next via fe98063.

This patch series was integrated into seen via 4814e32.

There was a status update in the "Cooking" section about the branch ll/doc-mktree-typofix on the Git mailing list:

Typofix.

Will merge to 'master'.
source: <pull.1207.git.git.1643792450866.gitgitgadget@gmail.com>

This patch series was integrated into seen via 649b334.

This patch series was integrated into seen via d23df48.

This patch series was integrated into seen via ecd7a93.

There was a status update in the "Cooking" section about the branch ll/doc-mktree-typofix on the Git mailing list:

Typofix.

Will merge to 'master'.
source: <pull.1207.git.git.1643792450866.gitgitgadget@gmail.com>

This patch series was integrated into seen via 00dd8d9.

This patch series was integrated into seen via dd77ff8.

This patch series was integrated into master via dd77ff8.

This patch series was integrated into next via dd77ff8.

Closed via dd77ff8.