Skip to content

Commit 863eb3c

Browse files
committed
chore(testing): update karma-jasmine and jasmine
Jasmine to jasmine-core 2.3.4. Update tools tests using minijasminenode to directly use jasmine. See angular#1860
1 parent b6b52e6 commit 863eb3c

5 files changed

Lines changed: 100 additions & 37 deletions

File tree

modules/angular2/src/test_lib/test_lib.es6

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@ export class AsyncTestCompleter {
3131

3232
var jsmBeforeEach = _global.beforeEach;
3333
var jsmDescribe = _global.describe;
34-
var jsmDDescribe = _global.ddescribe;
34+
var jsmDDescribe = _global.fdescribe;
3535
var jsmXDescribe = _global.xdescribe;
3636
var jsmIt = _global.it;
37-
var jsmIIt = _global.iit;
37+
var jsmIIt = _global.fit;
3838
var jsmXIt = _global.xit;
3939

4040
var runnerStack = [];

npm-shrinkwrap.clean.json

Lines changed: 31 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6933,6 +6933,36 @@
69336933
}
69346934
}
69356935
},
6936+
"jasmine": {
6937+
"version": "2.3.1",
6938+
"dependencies": {
6939+
"exit": {
6940+
"version": "0.1.2"
6941+
},
6942+
"glob": {
6943+
"version": "3.2.11",
6944+
"dependencies": {
6945+
"inherits": {
6946+
"version": "2.0.1"
6947+
},
6948+
"minimatch": {
6949+
"version": "0.3.0",
6950+
"dependencies": {
6951+
"lru-cache": {
6952+
"version": "2.6.4"
6953+
},
6954+
"sigmund": {
6955+
"version": "1.0.1"
6956+
}
6957+
}
6958+
}
6959+
}
6960+
}
6961+
}
6962+
},
6963+
"jasmine-core": {
6964+
"version": "2.3.4"
6965+
},
69366966
"js-beautify": {
69376967
"version": "1.5.5",
69386968
"dependencies": {
@@ -7593,7 +7623,7 @@
75937623
}
75947624
},
75957625
"karma-jasmine": {
7596-
"version": "0.2.3"
7626+
"version": "0.3.5"
75977627
},
75987628
"lodash": {
75997629
"version": "2.4.2"
@@ -7774,14 +7804,6 @@
77747804
"merge2": {
77757805
"version": "0.3.5"
77767806
},
7777-
"minijasminenode2": {
7778-
"version": "1.0.0",
7779-
"dependencies": {
7780-
"jasmine-core": {
7781-
"version": "2.0.0"
7782-
}
7783-
}
7784-
},
77857807
"minimatch": {
77867808
"version": "2.0.7",
77877809
"dependencies": {

npm-shrinkwrap.json

Lines changed: 49 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,19 +78,20 @@
7878
"gulp-webserver": "^0.8.7",
7979
"html2jade": "^0.8.3",
8080
"indent-string": "^1.2.1",
81+
"jasmine": "2.3.1",
82+
"jasmine-core": "2.3.4",
8183
"js-beautify": "^1.5.5",
8284
"js-yaml": "^3.2.7",
8385
"karma": "^0.12.23",
8486
"karma-chrome-launcher": "^0.1.4",
8587
"karma-cli": "^0.0.4",
8688
"karma-dart": "^0.2.8",
87-
"karma-jasmine": "^0.2.2",
89+
"karma-jasmine": "^0.3.5",
8890
"lodash": "^2.4.1",
8991
"madge": "^0.5.0",
9092
"marked": "^0.3.3",
9193
"merge": "^1.2.0",
9294
"merge2": "^0.3.5",
93-
"minijasminenode2": "^1.0.0",
9495
"minimatch": "^2.0.1",
9596
"minimist": "1.1.x",
9697
"mock-fs": "^2.5.0",

tools/traceur-jasmine/index.js

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
'use strict';
22

33
var glob = require('glob');
4-
var minijasminenode2 = require('minijasminenode2');
4+
var JasmineRunner = require('jasmine');
55
var path = require('path');
66
// Require traceur to exposes $traceurRuntime on global context so that CJS files can run
77
require('traceur/bin/traceur-runtime.js');
88
require('reflect-metadata/Reflect');
99

10+
var jrunner = new JasmineRunner();
11+
1012
// Support passing multiple globs
1113
var globsIndex = process.argv.indexOf('--');
1214
var args;
@@ -20,12 +22,16 @@ var specFiles = args.
2022
map(function(globstr) { return glob.sync(globstr); }).
2123
reduce(function(specFiles, paths) { return specFiles.concat(paths); }, []);
2224

23-
minijasminenode2.executeSpecs({
24-
includeStackTrace: true,
25-
defaultTimeoutInterval: 1000,
26-
showColors: process.argv.indexOf('--no-color') === -1,
27-
specs: specFiles,
28-
onComplete: function(passed) {
29-
process.exit(passed ? 0 : 1);
30-
}
25+
jasmine.DEFAULT_TIMEOUT_INTERVAL = 1000;
26+
27+
jrunner.configureDefaultReporter({
28+
showColors: process.argv.indexOf('--no-color') === -1
29+
});
30+
31+
jrunner.onComplete(function(passed) {
32+
process.exit(passed ? 0 : 1);
3133
});
34+
jrunner.projectBaseDir = path.resolve(__dirname, '../../');
35+
jrunner.specDir = '';
36+
jrunner.addSpecFiles(specFiles);
37+
jrunner.execute();

0 commit comments

Comments
 (0)