fix(facades): fix splice semantics; add test

yjbanov · yjbanov · commit 526c51d1a6c2 · 2015-04-17T13:52:03.000-07:00
diff --git a/modules/angular2/src/facade/collection.dart b/modules/angular2/src/facade/collection.dart
@@ -154,7 +154,8 @@ class ListWrapper {
   static List slice(List l, int from, int to) {
     return l.sublist(from, to);
   }
-  static List splice(List l, int from, int to) {
+  static List splice(List l, int from, int length) {
+    var to = from + length;
     var sub = l.sublist(from, to);
     l.removeRange(from, to);
     return sub;
diff --git a/modules/angular2/src/facade/collection.es6 b/modules/angular2/src/facade/collection.es6
@@ -193,8 +193,8 @@ export class ListWrapper {
   static slice(l:List, from:int, to:int):List {
     return l.slice(from, to);
   }
-  static splice(l:List, from:int, to:int):List {
-    return l.splice(from, to);
+  static splice(l:List, from:int, length:int):List {
+    return l.splice(from, length);
   }
   static sort(l:List, compareFn:Function) {
     l.sort(compareFn);
diff --git a/modules/angular2/src/facade/collection.ts b/modules/angular2/src/facade/collection.ts
@@ -168,6 +168,9 @@ export class ListWrapper {
     return true;
   }
   static slice<T>(l: List<T>, from: int, to: int): List<T> { return l.slice(from, to); }
+  static splice<T>(l:List<T>, from:int, length:int):List<T> {
+    return l.splice(from, length);
+  }
   static sort<T>(l: List<T>, compareFn: (a: T, b: T) => number) { l.sort(compareFn); }
 }
 
diff --git a/modules/angular2/test/facade/collection_spec.js b/modules/angular2/test/facade/collection_spec.js
@@ -0,0 +1,16 @@
+import {describe, it, expect, beforeEach, ddescribe, iit, xit}
+  from 'angular2/test_lib';
+
+import {List, ListWrapper} from 'angular2/src/facade/collection';
+
+export function main() {
+  describe('ListWrapper', () => {
+    describe('splice', () => {
+      it('should remove sublist of given length and return it',  () => {
+        var list = [1, 2, 3, 4, 5, 6];
+        expect(ListWrapper.splice(list, 1, 3)).toEqual([2, 3, 4]);
+        expect(list).toEqual([1, 5, 6]);
+      });
+    });
+ });
+}
diff --git a/modules/angular2_material/src/components/switcher/switch.js b/modules/angular2_material/src/components/switcher/switch.js
@@ -65,7 +65,7 @@ export class MdSwitch {
   }
 
   onKeydown(event: KeyboardEvent) {
-    if (event.keyCode == KEY_SPACE) {
+    if (event.keyCode === KEY_SPACE) {
       event.preventDefault();
       this.toggle(event);
     }

Original file line number	Diff line number	Diff line change
`@@ -193,8 +193,8 @@ export class ListWrapper {`
`193`	`193`	`static slice(l:List, from:int, to:int):List {`
`194`	`194`	`return l.slice(from, to);`
`195`	`195`	`}`
`196`		`- static splice(l:List, from:int, to:int):List {`
`197`		`- return l.splice(from, to);`
	`196`	`+ static splice(l:List, from:int, length:int):List {`
	`197`	`+ return l.splice(from, length);`
`198`	`198`	`}`
`199`	`199`	`static sort(l:List, compareFn:Function) {`
`200`	`200`	`l.sort(compareFn);`
Original file line number	Diff line number	Diff line change
`@@ -168,6 +168,9 @@ export class ListWrapper {`
`168`	`168`	`return true;`
`169`	`169`	`}`
`170`	`170`	`static slice<T>(l: List<T>, from: int, to: int): List<T> { return l.slice(from, to); }`
	`171`	`+ static splice<T>(l:List<T>, from:int, length:int):List<T> {`
	`172`	`+ return l.splice(from, length);`
	`173`	`+ }`
`171`	`174`	`static sort<T>(l: List<T>, compareFn: (a: T, b: T) => number) { l.sort(compareFn); }`
`172`	`175`	`}`
`173`	`176`
Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ export class MdSwitch {`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`onKeydown(event: KeyboardEvent) {`
`68`		`- if (event.keyCode == KEY_SPACE) {`
	`68`	`+ if (event.keyCode === KEY_SPACE) {`
`69`	`69`	`event.preventDefault();`
`70`	`70`	`this.toggle(event);`
`71`	`71`	`}`