Skip to content

chore(sqlalchemy): Drop transaction-based tracing - #7199

Draft
sentrivana wants to merge 3 commits into
ivana/major/remove-transactions-asyncpgfrom
ivana/major/remove-transactions-sqlalchemy
Draft

chore(sqlalchemy): Drop transaction-based tracing#7199
sentrivana wants to merge 3 commits into
ivana/major/remove-transactions-asyncpgfrom
ivana/major/remove-transactions-sqlalchemy

Conversation

@sentrivana

Copy link
Copy Markdown
Contributor

Closes PY-2733
Closes #7198

@linear-code

linear-code Bot commented Aug 13, 2026

Copy link
Copy Markdown

PY-2733

@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

104356 passed | ❌ 1 failed | ⏭️ 5350 skipped | Total: 109707 | Pass Rate: 95.12% | Execution Time: 376m 42s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -9515
Passed Tests 📉 -8107
Failed Tests 📈 +1
Skipped Tests 📉 -1409

➕ New Tests (1)

View new tests
  • test_span_streaming_quart_auth_user_id[42-True]
    • File: tests.integrations.quart.test_quart
    • Status: ❌ Failing

❌ Failed Tests

test_span_streaming_quart_auth_user_id[42-True]

File: tests.integrations.quart.test_quart
Suite: py3.11-quart-v0.21.0
Error: KeyError: 'user.id'

Stack Trace
tests/integrations/quart/test_quart.py:1039: in test_span_streaming_quart_auth_user_id
    assert segment["attributes"]["user.id"] == user_id
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E   KeyError: 'user.id'

✅ Patch coverage is 85.71%. Project has 2267 uncovered lines.
✅ Project coverage is 90.5%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/sqlalchemy.py 85.71% ⚠️ 2 Missing and 2 partials
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.23%    90.50%    +0.27%
==========================================
  Files          193       185        -8
  Lines        25361     23873     -1488
  Branches      9302      8776      -526
==========================================
+ Hits         22883     21606     -1277
- Misses        2478      2267      -211
- Partials      1432      1369       -63

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant