fix(spans): Add `http.route` attribute to HTTP server spans by mjq · Pull Request #7183 · getsentry/sentry-python

mjq · 2026-08-12T18:53:02Z

Description

Currently the HTTP path template is only available in the span name. Make it available as a semantic attribute as well (http.route - definition in conventions).

This will also let us use this in e.g. HTTP server span description generation, which will be necessary to maintain consistent descriptions between transactions and span streaming.

Issues

resolves: PY-2732
resolves: http.route missing from HTTP server spans #7182

linear-code · 2026-08-12T18:53:06Z

PY-2732

github-actions · 2026-08-12T19:05:18Z

Codecov Results 📊

📊 Comparison with Base Branch

Metric	Change
Total Tests	📉 -1037
Passed Tests	📉 -1037
Failed Tests	📈 +2
Skipped Tests	📉 -2

➕ New Tests (3)

View new tests

test_cache_spans_item_size[True]
- File: tests.integrations.django.test_cache_module
- Status: ❌ Failing
test_cache_spans_decorator[True]
- File: tests.integrations.django.test_cache_module
- Status: ❌ Failing
test_aggregates
- File: tests.test_sessions
- Status: ❌ Failing

➖ Removed Tests (1)

View removed tests

test_span_streaming_quart_auth_user_id[42-True]
- File: tests.integrations.quart.test_quart

❌ Failed Tests

`test_cache_spans_item_size[True]`

File: tests.integrations.django.test_cache_module
Suite: py3.10-django-v5.2.17
Error: tests/integrations/django/test_cache_module.py:764: in test_cache_spans_item_size assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace

tests/integrations/django/test_cache_module.py:764: in test_cache_spans_item_size
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

`test_cache_spans_decorator[True]`

File: tests.integrations.django.test_cache_module
Suite: py3.13-django-v5.2.17
Error: tests/integrations/django/test_cache_module.py:385: in test_cache_spans_decorator assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace

tests/integrations/django/test_cache_module.py:385: in test_cache_spans_decorator
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

`test_aggregates`

File: tests.test_sessions
Suite: py3.14t-common
Error: AssertionError: assert 2 == 1 + where 2 = len([{'started': '2026-08-13T20:21:00.000000Z', 'errored': 1}, {'started': '2026-08-13T20:22:00.000000Z', 'exited': 2}])

Stack Trace

tests/test_sessions.py:81: in test_aggregates
    assert len(aggregates) == 1
E   AssertionError: assert 2 == 1
E    +  where 2 = len([{'started': '2026-08-13T20:21:00.000000Z', 'errored': 1}, {'started': '2026-08-13T20:22:00.000000Z', 'exited': 2}])

✅ Patch coverage is 95.24%. Project has 2491 uncovered lines.
✅ Project coverage is 90.21%. Comparing base (base) to head (head).

Files with missing lines (1)

File	Patch %	Lines
sentry_sdk/integrations/asgi.py	80.00%	⚠️ 1 Missing and 1 partials

Coverage diff

@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.21%    90.21%        —%
==========================================
  Files          193       193         —
  Lines        25423     25444       +21
  Branches      9336      9350       +14
==========================================
+ Hits         22933     22953       +20
- Misses        2490      2491        +1
- Partials      1436      1438        +2

Generated by Codecov Action

sentry-warden · 2026-08-12T19:08:29Z

                                        )
+                                        if (
+                                            source == SegmentNameSource.ROUTE.value
+                                            and name != _DEFAULT_TRANSACTION_NAME


scope.py sets http.route on default transaction names without matching guard

The ASGI middleware correctly avoids writing http.route for fallback transaction names, but scope.set_transaction_name() in the same PR lacks the same guard. When FastAPI or Starlette hit a 404 and call scope.set_transaction_name(default, ROUTE), http.route is set to a generic string rather than a route template.

Evidence

scope.py set_transaction_name unconditionally sets SPANDATA.HTTP_ROUTE whenever source_value == SegmentNameSource.ROUTE.value, without checking name != _DEFAULT_TRANSACTION_NAME.

Both FastAPI and Starlette call scope.set_transaction_name(_DEFAULT_TRANSACTION_NAME, TransactionSource.ROUTE) when no route matches the request.

For streaming spans, that causes http.route to be set to values like "generic FastAPI request" in attributes, while this hunk explicitly avoids writing the attribute in the same circumstance.

_{Identified by Warden · code-review · DS5-DYC}

mjq · 2026-08-13T20:16:32Z

@sentry review

mjq · 2026-08-13T20:16:37Z

@cursor review

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit b1363a5. Configure here.}

cursor · 2026-08-13T20:20:17Z

        name = _DEFAULT_TRANSACTION_NAME
        source = TransactionSource.ROUTE
+    elif source == TransactionSource.ROUTE:
+        scope.set_segment_attribute(SPANDATA.HTTP_ROUTE, name)


Starlette sync skips http.route

Medium Severity

set_segment_attribute only writes http.route when the given scope already holds a StreamedSpan. Starlette's sync handler calls _set_transaction_name_and_source with the isolation scope, whose _span is unset, so the attribute is silently dropped for sync endpoints. Async handlers use the current scope and are unaffected.

^{Reviewed by Cursor Bugbot for commit b1363a5. Configure here.}

cursor Bot reviewed Aug 12, 2026

View reviewed changes

Comment thread sentry_sdk/scope.py Outdated

sentry-warden Bot reviewed Aug 12, 2026

View reviewed changes

fix(spans): Add http.route attribute to HTTP server spans

b1363a5

mjq force-pushed the mjq/http-route-server-spans branch from dddf367 to b1363a5 Compare August 13, 2026 20:16

cursor Bot reviewed Aug 13, 2026

View reviewed changes

mjq mentioned this pull request Aug 13, 2026

fix(starlette): Set transaction name on current scope in sync handler #7201

Draft

Navigation Menu

Uh oh!

fix(spans): Add `http.route` attribute to HTTP server spans - #7183

fix(spans): Add `http.route` attribute to HTTP server spans#7183
mjq wants to merge 1 commit into
masterfrom
mjq/http-route-server-spans

mjq commented Aug 12, 2026

Uh oh!

linear-code Bot commented Aug 12, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 12, 2026 •

edited

Loading

Uh oh!

sentry-warden Bot Aug 12, 2026

Uh oh!

mjq commented Aug 13, 2026

Uh oh!

mjq commented Aug 13, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

cursor Bot Aug 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

mjq commented Aug 12, 2026

Description

Issues

Uh oh!

linear-code Bot commented Aug 12, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Results 📊

📊 Comparison with Base Branch

➕ New Tests (3)

➖ Removed Tests (1)

❌ Failed Tests

test_cache_spans_item_size[True]

test_cache_spans_decorator[True]

test_aggregates

Uh oh!

sentry-warden Bot Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

mjq commented Aug 13, 2026

Uh oh!

mjq commented Aug 13, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Aug 13, 2026

Choose a reason for hiding this comment

Starlette sync skips http.route

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions Bot commented Aug 12, 2026 •

edited

Loading

`test_cache_spans_item_size[True]`

`test_cache_spans_decorator[True]`

`test_aggregates`