Skip to content

chore(strawberry): Remove transaction-based tracing - #7166

Draft
sentrivana wants to merge 2 commits into
major/3.0from
ivana/major/remove-transactions-strawberry
Draft

chore(strawberry): Remove transaction-based tracing#7166
sentrivana wants to merge 2 commits into
major/3.0from
ivana/major/remove-transactions-strawberry

Conversation

@sentrivana

@sentrivana sentrivana commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Hide whitespace for a much easier time reviewing

Issues

Closes PY-2722
Closes #7118

@linear-code

linear-code Bot commented Aug 11, 2026

Copy link
Copy Markdown

PY-2722

@sentrivana
sentrivana marked this pull request as ready for review August 11, 2026 13:53
@sentrivana
sentrivana requested a review from a team as a code owner August 11, 2026 13:53
cursor[bot]
cursor Bot reviewed Aug 11, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4445c6e. Configure here.

Comment thread sentry_sdk/integrations/strawberry.py

elif should_send_default_pii():
additional_attributes["graphql.document"] = self.execution_context.query
if sentry_sdk.traces.get_current_span() is None:

@cursor cursor Bot Aug 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead resource name helpers remain

Low Severity

_resource_name and hash_query are unused after the static tracing path was removed. Their only call site set graphql.resource_name on legacy spans, so these helpers (and the hashlib import they need) are now dead code.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 4445c6e. Configure here.

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 97394 passed | ❌ 1 failed | ⏭️ 5393 skipped | Total: 102788 | Pass Rate: 94.75% | Execution Time: 336m 18s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -8291
Passed Tests 📉 -7008
Failed Tests 📈 +1
Skipped Tests 📉 -1284

➕ New Tests (1)

View new tests
  • test_nonstreaming_chat_completion[False-True-False-False]
    • File: tests.integrations.litellm.test_litellm
    • Status: ❌ Failing

❌ Failed Tests

test_nonstreaming_chat_completion[False-True-False-False]

File: tests.integrations.litellm.test_litellm
Suite: py3.10-litellm-v1.83.14
Error: pytest.PytestUnraisableExceptionWarning: Exception ignored in thread started by: <bound method Thread._bootstrap of <Thread(Thread-6 (_flush_loop), started daemon 140149514032704)>> Enable tracemalloc to get traceback where the object was allocated. See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

Stack Trace 
/usr/lib/python3.10/threading.py:973: in _bootstrap
    self._bootstrap_inner()
/usr/lib/python3.10/threading.py:1011: in _bootstrap_inner
    _sys.settrace(_trace_hook)
E   RuntimeError: Cannot install a trace function while another trace function is being installed

The above exception was the direct cause of the following exception:
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/_pytest/runner.py:361: in from_call
    result: TResult | None = func()
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/_pytest/runner.py:250: in <lambda>
    lambda: runtest_hook(item=item, **kwds),
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/pluggy/_hooks.py:512: in __call__
    return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/pluggy/_manager.py:120: in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/_pytest/logging.py:865: in pytest_runtest_call
    yield
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/pluggy/_callers.py:53: in run_old_style_hookwrapper
    return result.get_result()
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/pluggy/_callers.py:38: in run_old_style_hookwrapper
    res = yield
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/_pytest/capture.py:900: in pytest_runtest_call
    return (yield)
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/_pytest/skipping.py:268: in pytest_runtest_call
    return (yield)
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/_pytest/unraisableexception.py:183: in pytest_runtest_call
    collect_unraisable(item.config)
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/_pytest/unraisableexception.py:79: in collect_unraisable
    raise errors[0]
.tox/py3.10-litellm-v1.83.14/lib/python3.10/site-packages/_pytest/unraisableexception.py:67: in collect_unraisable
    warnings.warn(pytest.PytestUnraisableExceptionWarning(msg))
E   pytest.PytestUnraisableExceptionWarning: Exception ignored in thread started by: <bound method Thread._bootstrap of <Thread(Thread-6 (_flush_loop), started daemon 140149514032704)>>
E   Enable tracemalloc to get traceback where the object was allocated.
E   See https://docs.pytest.org/en/stable/how-to/capture-warnings.html#resource-warnings for more info.

✅ Patch coverage is 100.00%. Project has 2262 uncovered lines.
✅ Project coverage is 90.47%. Comparing base (base) to head (head).

Coverage diff 
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.14%    90.47%    +0.33%
==========================================
  Files          193       185        -8
  Lines        25183     23742     -1441
  Branches      9176      8660      -516
==========================================
+ Hits         22700     21480     -1220
- Misses        2483      2262      -221
- Partials      1429      1366       -63

Generated by Codecov Action

@sentrivana
sentrivana marked this pull request as draft August 11, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sentrivana