ci: Remove tomli from requirements-testing.txt#6630
Open
alexander-alderman-webb wants to merge 1 commit into
Open
ci: Remove tomli from requirements-testing.txt#6630alexander-alderman-webb wants to merge 1 commit into
tomli from requirements-testing.txt#6630alexander-alderman-webb wants to merge 1 commit into
Conversation
Contributor
Codecov Results 📊✅ 91388 passed | ⏭️ 6136 skipped | Total: 97524 | Pass Rate: 93.71% | Execution Time: 335m 35s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2412 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.85% 89.85% —%
==========================================
Files 192 192 —
Lines 23758 23758 —
Branches 8204 8204 —
==========================================
+ Hits 21347 21346 -1
- Misses 2411 2412 +1
- Partials 1344 1345 +1Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tomliis already declared as a dependency of pytest:https://github.com/pytest-dev/pytest/blob/2eac0d6cfe0be3d2d49b86c3860ee00f60517813/pyproject.toml#L56
Remove the package from
requirements-testing.txtand add the package as a dependency to only the test suites that rely on the package (if applicable).This is part of environment cleanup before moving the remaining testing dependencies to a uv dependency group.
Issues
Reminders
uv run ruff.feat:,fix:,ref:,meta:)