test(node-integration-tests): Remove dead Node 18 test gating - #23434
Draft
nicohrubec wants to merge 1 commit into
Draft
test(node-integration-tests): Remove dead Node 18 test gating#23434nicohrubec wants to merge 1 commit into
nicohrubec wants to merge 1 commit into
Conversation
Node 18 (and everything below 20.19) was dropped in v11, so the Node-version gates in the integration/unit tests can no longer branch: `max: 18` blocks never run, `min: 19/20` gates are always true, and the vercelai v6/v7 matrix no longer needs its Node 18 fork. Unwrap them to plain describe/test and drop the now-unused imports. Runtime `tracingChannel` guards in the instrumentations are intentionally left in place. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer support Node 18, so this drops the now-redundant Node-version gating from the tests.