Skip to content

ref(core)!: Migrate to SENTRY_SEGMENT_NAME_SOURCE - #23368

Draft
RulaKhaled wants to merge 2 commits into
developfrom
feat/segment-name-source-impl
Draft

ref(core)!: Migrate to SENTRY_SEGMENT_NAME_SOURCE#23368
RulaKhaled wants to merge 2 commits into
developfrom
feat/segment-name-source-impl

Conversation

@RulaKhaled

@RulaKhaled RulaKhaled commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Besides removing SEMANTIC_ATTRIBUTE_SENTRY_SOURCE and using SENTRY_SEGMENT_NAME_SOURCE instead, this PR also:

  • Sets name source only on segment spans (per the Sentry segment name source convention) — e.g. updateName, HTTP server spans, and tRPC when it is the segment root
  • Removes envelope-time backfill from sentry.source → sentry.segment.name.source in captureSpan

CI note: This PR alone is expected to fail CI. It will stay blocked until #23367 is merged into it — that split is intentional to keep the core changes easier to review.

Fixes #22259

@RulaKhaled RulaKhaled mentioned this pull request Aug 12, 2026
Draft
@RulaKhaled
RulaKhaled force-pushed the feat/segment-name-source-impl branch from 8f4804b to 16a4997 Compare August 12, 2026 13:56
@github-actions

github-actions Bot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 30.3 kB -0.13% -37 B 🔽
@sentry/browser - with treeshaking flags 28.48 kB -0.12% -34 B 🔽
@sentry/browser - with treeshaking flags tracing without tracing 26.85 kB -0.02% -5 B 🔽
@sentry/browser (incl. Tracing) 48.54 kB -0.06% -27 B 🔽
@sentry/browser (incl. Tracing + Span Streaming) 48.56 kB -0.05% -22 B 🔽
@sentry/browser (incl. Tracing, Profiling) 51.43 kB -0.06% -26 B 🔽
@sentry/browser (incl. Tracing, Replay) 87.95 kB -0.04% -31 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 77.36 kB -0.01% -2 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 92.68 kB -0.03% -22 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 105.38 kB +0.01% +2 B 🔺
@sentry/browser (incl. Feedback) 47.62 kB -0.08% -35 B 🔽
@sentry/browser (incl. sendFeedback) 35.13 kB -0.1% -32 B 🔽
@sentry/browser (incl. FeedbackAsync) 40.28 kB -0.07% -27 B 🔽
@sentry/browser (incl. Metrics) 31.26 kB -0.16% -50 B 🔽
@sentry/browser (incl. Logs) 31.53 kB -0.15% -47 B 🔽
@sentry/browser (incl. Metrics & Logs) 32.2 kB -0.16% -49 B 🔽
@sentry/react 32.09 kB -0.13% -40 B 🔽
@sentry/react (incl. Tracing) 50.75 kB -0.07% -32 B 🔽
@sentry/vue 35.32 kB -0.12% -39 B 🔽
@sentry/vue (incl. Tracing) 50.5 kB -0.05% -25 B 🔽
@sentry/svelte 30.33 kB -0.13% -37 B 🔽
CDN Bundle 31.6 kB -0.14% -44 B 🔽
CDN Bundle (incl. Tracing) 48.86 kB -0.08% -35 B 🔽
CDN Bundle (incl. Logs, Metrics) 33.82 kB -0.14% -45 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) 50.82 kB -0.08% -38 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) 74.36 kB -0.03% -18 B 🔽
CDN Bundle (incl. Tracing, Replay) 86.45 kB -0.05% -37 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.34 kB -0.02% -17 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 92.16 kB -0.04% -36 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 94.15 kB -0.03% -22 B 🔽
CDN Bundle - uncompressed 93.84 kB -0.11% -99 B 🔽
CDN Bundle (incl. Tracing) - uncompressed 146.72 kB -0.07% -96 B 🔽
CDN Bundle (incl. Logs, Metrics) - uncompressed 100.24 kB -0.1% -99 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 152.51 kB -0.07% -96 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 229.2 kB -0.04% -73 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 266 kB -0.03% -70 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 271.78 kB -0.03% -70 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 279.7 kB -0.03% -70 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 285.47 kB -0.03% -70 B 🔽
@sentry/nextjs (client) 53.29 kB -0.02% -9 B 🔽
@sentry/sveltekit (client) 48.95 kB -0.08% -35 B 🔽
@sentry/core/server 65.44 kB -0.02% -13 B 🔽
@sentry/core/browser 51.79 kB -0.05% -25 B 🔽
@sentry/node 117.96 kB -0.02% -21 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection) 0 B added added
@sentry/node - without tracing 82.06 kB -0.05% -37 B 🔽
@sentry/aws-serverless 91.49 kB -0.02% -18 B 🔽
@sentry/cloudflare (withSentry) - minified 214.09 kB -0.02% -31 B 🔽
@sentry/cloudflare (withSentry) 528.56 kB -0.09% -462 B 🔽

View base workflow run

@RulaKhaled
RulaKhaled force-pushed the feat/segment-name-source-impl branch from 16a4997 to f187f70 Compare August 12, 2026 14:08
@RulaKhaled RulaKhaled changed the title ref!: Migrate to SENTRY_SEGMENT_NAME_SOURCE ref(core)!: Migrate to SENTRY_SEGMENT_NAME_SOURCE Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename SEMANTIC_ATTRIBUTE_SENTRY_SOURCE to sentry.segment.name.source & drop semanticAttributes re-export

1 participant

@RulaKhaled