feat(sveltekit)!: Remove unstable_sentryVitePluginOptions - #23366
Draft
Conversation
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 825192d. Configure here.
| await getSentrySvelteKitPlugins({ org: 'my-org' }); | ||
|
|
||
| expect(consoleWarnSpy).not.toHaveBeenCalledWith(expect.stringContaining('unstable_')); | ||
| }); |
There was a problem hiding this comment.
Feat PR lacks integration tests
Low Severity
This feat PR only adds unit coverage for the unstable_sentryVitePluginOptions removal warning and option wiring. Per the Testing Conventions review rule, a feat PR needs at least one integration or E2E test that exercises the new behavior.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 825192d. Configure here.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chargome
force-pushed
the
charlygomez/js-3361-sveltekit-remove-unstable_sentryvitepluginoptions
branch
from
August 12, 2026 14:51
825192d to
0b3080e
Compare
chargome
changed the base branch from
charlygomez/js-3355-core-add-build-time-options-for-bundler-plugin-parity
to
charlygomez/js-3356-nuxt-remove-unstable_sentrybundlerpluginoptions
August 12, 2026 14:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
unstable_sentryVitePluginOptionsfrom the SvelteKit plugin options.Everything it exposed is reachable as a top-level build option. Adds a build-time warning for plain JS configs, where TypeScript cannot catch the removed key.
closes #23345