feat(server-utils)!: Align AMQP and Redis span attributes - #23324
Draft
s1gr1d wants to merge 5 commits into
Draft
Conversation
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2e3eef9. Configure here.
| 'net.peer.port': 6380, | ||
| 'db.statement': 'incr test-key', | ||
| ...redisData, | ||
| 'db.query.text': 'incr test-key', |
There was a problem hiding this comment.
Wrong Redis query attribute in tests
Medium Severity
The Redis auto-instrumentation expectations always assert db.query.text, including on the non-orchestrion path. That path still comes from OTel and emits db.statement. The adjacent redis-cache suite already branches this with dbQueryTextAttribute, so these assertions will fail whenever orchestrion is disabled.
Reviewed by Cursor Bugbot for commit 2e3eef9. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align AMQP, Redis, and ioredis tracing-channel spans with the current Sentry semantic conventions.
Closes #22363