feat(v10/core)!: Enable logs by default - #23311
Open
nicohrubec wants to merge 1 commit into
Open
Conversation
Contributor
size-limit report 📦
|
nicohrubec
force-pushed
the
feat/v10-enable-logs-by-default
branch
from
August 11, 2026 19:10
eba4cdb to
68b7ff1
Compare
Backport of: #22630
nicohrubec
force-pushed
the
feat/v10-enable-logs-by-default
branch
from
August 11, 2026 19:14
68b7ff1 to
c282a54
Compare
nicohrubec
marked this pull request as ready for review
August 11, 2026 19:30
nicohrubec
requested review from
JPeer264,
Lms24,
andreiborza,
chargome,
logaretm,
mydea and
s1gr1d
and removed request for
a team
August 11, 2026 19:30
logaretm
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: #22630
Flips the
enableLogsclient option to default totrueso users get logs without opting in, matching howenableMetricsalready behaves. An explicitenableLogs: falseturns it back off. Unless a logging integration is added or an explicit logging API is called no logs are emitted.Main difference to the original PR is that on v10 node and node-core are still separate packages so we need a few changes in both. Also added a changelog entry since this is a behavioral change.
Note e2e failures are during the build so seems unrelated. Docs also need updating.