feat: Rename deprecated net. span attributes - #23301
Conversation
|
bugbot run |
|
|
||
| String and regular-expression matching for `tracePropagationTargets` is now case-insensitive. | ||
|
|
||
| ### Span attribute changes |
There was a problem hiding this comment.
I added all already existing entries regarding attribute changes under this heading.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 43ead46. Configure here.
| 'net.peer.name': 'localhost', | ||
| 'net.peer.port': port, | ||
| 'server.address': 'localhost', | ||
| 'network.peer.port': port, |
There was a problem hiding this comment.
DB tests expect wrong port attribute
High Severity
Database client tests were updated to assert network.peer.port, but the matching instrumentation now emits server.port (via SERVER_PORT). Unit tests such as ioredis/postgres already expect server.port, so these integration and E2E assertions will fail across mysql, mongo, redis, knex, tedious, and similar suites.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 43ead46. Configure here.
| attributes, | ||
| NETWORK_PROTOCOL_NAME, | ||
| urlObject && !('isRelative' in urlObject) ? urlObject.protocol.slice(0, -1) : undefined, | ||
| ); |
There was a problem hiding this comment.
Deno protocol name can be https
Low Severity
New network.protocol.name is derived from the URL scheme, so HTTPS requests get https. Elsewhere this PR hardcodes http and documents network.protocol.name: "http" with the version in network.protocol.version. Scheme belongs in url.scheme.
Reviewed by Cursor Bugbot for commit 43ead46. Configure here.
size-limit report 📦
|
Related to Linear: https://linear.app/getsentry/issue/SDK-1348/align-network-span-attributes
net.host.nameserver.addressnet.host.ipnetwork.local.addressnet.host.portnetwork.local.portnet.peer.nameserver.addressnet.peer.ipnetwork.peer.addressnet.peer.portnetwork.peer.portnet.transportnetwork.transport