Skip to content

ref(core): Remove OTel span handling from spanToJSON - #23281

Draft
Lms24 wants to merge 2 commits into
lms/spanToJSON-returns-streamedfrom
lms/ref-core-no-otel-spanToJSON
Draft

ref(core): Remove OTel span handling from spanToJSON#23281
Lms24 wants to merge 2 commits into
lms/spanToJSON-returns-streamedfrom
lms/ref-core-no-otel-spanToJSON

Conversation

@Lms24

@Lms24 Lms24 commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

WIP: needs #23198

Now that our SDK only emits SentrySpan, even when our tracer provider is used, we can streamline the spanToJSON helper, to no longer handle OTel spans. This should reduce some bytes and complexity.

@Lms24
Lms24 marked this pull request as draft August 11, 2026 12:17
@github-actions

github-actions Bot commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 29.67 kB -1.91% -576 B 🔽
@sentry/browser - with treeshaking flags 27.88 kB -1.95% -553 B 🔽
@sentry/browser - with treeshaking flags tracing without tracing 26.34 kB -1.57% -420 B 🔽
@sentry/browser (incl. Tracing) 48.39 kB -0.22% -103 B 🔽
@sentry/browser (incl. Tracing + Span Streaming) 48.41 kB -0.22% -104 B 🔽
@sentry/browser (incl. Tracing, Profiling) 51.28 kB -0.21% -103 B 🔽
@sentry/browser (incl. Tracing, Replay) 87.79 kB -0.16% -136 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 77.11 kB -0.23% -175 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 92.52 kB -0.13% -115 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 105.17 kB -0.14% -142 B 🔽
@sentry/browser (incl. Feedback) 47.01 kB -1.17% -555 B 🔽
@sentry/browser (incl. sendFeedback) 34.49 kB -1.64% -572 B 🔽
@sentry/browser (incl. FeedbackAsync) 39.66 kB -1.4% -560 B 🔽
@sentry/browser (incl. Metrics) 30.73 kB -1.71% -534 B 🔽
@sentry/browser (incl. Logs) 30.98 kB -1.76% -552 B 🔽
@sentry/browser (incl. Metrics & Logs) 31.66 kB -1.68% -538 B 🔽
@sentry/react 31.51 kB -1.69% -539 B 🔽
@sentry/react (incl. Tracing) 50.54 kB -0.27% -132 B 🔽
@sentry/vue 35.17 kB -0.39% -137 B 🔽
@sentry/vue (incl. Tracing) 50.34 kB -0.2% -96 B 🔽
@sentry/svelte 29.7 kB -1.88% -569 B 🔽
CDN Bundle 30.94 kB -1.81% -569 B 🔽
CDN Bundle (incl. Tracing) 48.65 kB -0.3% -142 B 🔽
CDN Bundle (incl. Logs, Metrics) 33.2 kB -1.55% -520 B 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) 50.64 kB -0.21% -102 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) 73.69 kB -0.76% -560 B 🔽
CDN Bundle (incl. Tracing, Replay) 86.24 kB -0.18% -150 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.14 kB -0.17% -144 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 91.95 kB -0.16% -145 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 93.97 kB -0.13% -117 B 🔽
CDN Bundle - uncompressed 91.85 kB -1.83% -1.71 kB 🔽
CDN Bundle (incl. Tracing) - uncompressed 145.91 kB -0.37% -537 B 🔽
CDN Bundle (incl. Logs, Metrics) - uncompressed 98.32 kB -1.65% -1.64 kB 🔽
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 151.77 kB -0.32% -476 B 🔽
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 227.25 kB -0.72% -1.63 kB 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 265.17 kB -0.2% -527 B 🔽
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 271.01 kB -0.18% -466 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 278.87 kB -0.19% -527 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 284.7 kB -0.17% -466 B 🔽
@sentry/nextjs (client) 53.09 kB -0.27% -139 B 🔽
@sentry/sveltekit (client) 48.81 kB -0.18% -87 B 🔽
@sentry/core/server 65.32 kB -0.18% -113 B 🔽
@sentry/core/browser 51.65 kB -0.27% -137 B 🔽
@sentry/node 117.75 kB -0.14% -156 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection) 0 B added added
@sentry/node - without tracing 81.9 kB -0.17% -132 B 🔽
@sentry/aws-serverless 91.26 kB -0.2% -179 B 🔽
@sentry/cloudflare (withSentry) - minified 213.32 kB -0.33% -702 B 🔽
@sentry/cloudflare (withSentry) 527.29 kB -0.25% -1.32 kB 🔽

View base workflow run

@Lms24
Lms24 force-pushed the lms/ref-core-no-otel-spanToJSON branch from cb8ee5f to fb581ce Compare August 11, 2026 12:26
cursor[bot]
cursor Bot reviewed Aug 11, 2026
View reviewed changes
Comment thread packages/core/src/utils/spanUtils.ts
@Lms24 Lms24 mentioned this pull request Aug 11, 2026
Open
@Lms24
Lms24 force-pushed the lms/ref-core-no-otel-spanToJSON branch from d515daa to 62036a4 Compare August 11, 2026 15:00
cursor[bot]
cursor Bot reviewed Aug 11, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 62036a4. Configure here.

Comment thread packages/core/src/types/span.ts
@Lms24
Lms24 force-pushed the lms/ref-core-no-otel-spanToJSON branch 2 times, most recently from f68a41a to 0e45544 Compare August 11, 2026 15:33
@Lms24
Lms24 force-pushed the lms/ref-core-no-otel-spanToJSON branch from 0e45544 to 6c6cb1e Compare August 11, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Lms24