ref(browser): Extract browser-specific normalize code into registerable util#21172
Draft
mydea wants to merge 6 commits into
Draft
ref(browser): Extract browser-specific normalize code into registerable util#21172mydea wants to merge 6 commits into
normalize code into registerable util#21172mydea wants to merge 6 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3ed69bb. Configure here.
| return () => { | ||
| baseUnregister(); | ||
| unregister = undefined; | ||
| }; |
There was a problem hiding this comment.
Idempotent unregister breaks re-registration
Medium Severity
When registerDomEventNormalizer() runs while a registration already exists, it returns the raw addNormalizeUnpacker teardown instead of the wrapper that clears module state. Calling that teardown removes the unpacker but leaves the module unregister reference set, so later calls hit the idempotent branch and never call addNormalizeUnpacker again—DOM Event normalization stays off until the module reloads.
Reviewed by Cursor Bugbot for commit 3ed69bb. Configure here.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today, we have some browser-specific code in
corethat runs for all runtimes. Mainly this is around (browser)Event, which can havetargetandcurrentTargetdefined which are HTML elements. We have some code in place handling this in a custom way.This PR moves this code into
browser-utilsand changes it so this only runs in browser environments. There are two callsites:extractExceptionKeysForMessage- this is easy because we can just use the browser-utils implementation in the browser package, and use an implementation without Event support in core.normalize- this is harder because this is called from other core code, mainlyprepareEvent.To solve 2, this PR adds a
addNormalizeUnpackermethod that can be called to register a custom normalize unpacking function. So in core, nothing runs, while in browser this is called to register an additional unpacker for events.