refactor(core): replace public any types with unknown (#21249)

AI-DEV-BOT · isaacs · web-flow · commit fe644645306a · 2026-07-21T21:51:59.000Z
- Replace the remaining `TODO: fix in v11` public `any` types in core type definitions with `unknown` or `Record<string, unknown>`. - Type `isInstanceOf` around `unknown` inputs while keeping the existing invalid-constructor guard behavior. - Remove now-unnecessary `Error` assertions in aggregate error handling after the stricter type guard narrowing. Fixes #18570 Co-authored-by: isaacs <i@izs.me>
diff --git a/packages/core/src/types/error.ts b/packages/core/src/types/error.ts
@@ -2,7 +2,5 @@
  * Just an Error object with arbitrary attributes attached to it.
  */
 export interface ExtendedError extends Error {
-  // TODO: fix in v11, convert any to unknown
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  [key: string]: any;
+  [key: string]: unknown;
 }
diff --git a/packages/core/src/types/misc.ts b/packages/core/src/types/misc.ts
@@ -4,9 +4,7 @@ import type { QueryParams } from './request';
  * Data extracted from an incoming request to a node server
  */
 export interface ExtractedNodeRequestData {
-  // TODO: fix in v11, convert any to unknown
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  [key: string]: any;
+  [key: string]: unknown;
 
   /** Specific headers from the request */
   headers?: { [key: string]: string };
diff --git a/packages/core/src/types/samplingcontext.ts b/packages/core/src/types/samplingcontext.ts
@@ -6,9 +6,7 @@ import type { SpanAttributes } from './span';
  * Context data passed by the user when starting a transaction, to be used by the tracesSampler method.
  */
 export interface CustomSamplingContext {
-  // TODO: fix in v11, convert any to unknown
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  [key: string]: any;
+  [key: string]: unknown;
 }
 
 /**
diff --git a/packages/core/src/types/stackframe.ts b/packages/core/src/types/stackframe.ts
@@ -13,11 +13,7 @@ export interface StackFrame {
   in_app?: boolean;
   instruction_addr?: string;
   addr_mode?: string;
-  // TODO: fix in v11, convert any to unknown
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  vars?: { [key: string]: any };
+  vars?: { [key: string]: unknown };
   debug_id?: string;
-  // TODO: fix in v11, convert any to unknown
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  module_metadata?: any;
+  module_metadata?: Record<string, unknown>;
 }
diff --git a/packages/core/src/types/user.ts b/packages/core/src/types/user.ts
@@ -2,9 +2,7 @@
  * An interface describing a user of an application or a handled request.
  */
 export interface User {
-  // TODO: fix in v11, convert any to unknown
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  [key: string]: any;
+  [key: string]: unknown;
   id?: string | number;
   ip_address?: string | null;
   email?: string;
diff --git a/packages/core/src/utils/aggregate-errors.ts b/packages/core/src/utils/aggregate-errors.ts
@@ -57,7 +57,7 @@ function aggregateExceptionsFromError(
   // Recursively call this function in order to walk down a chain of errors
   if (isInstanceOf(error[key], Error)) {
     applyExceptionGroupFieldsForParentException(exception, exceptionId, error);
-    const newException = exceptionFromErrorImplementation(parser, error[key] as Error);
+    const newException = exceptionFromErrorImplementation(parser, error[key]);
     const newExceptionId = newExceptions.length;
     applyExceptionGroupFieldsForChildException(newException, key, newExceptionId, exceptionId);
     newExceptions = aggregateExceptionsFromError(
@@ -78,7 +78,7 @@ function aggregateExceptionsFromError(
     error.errors.forEach((childError, i) => {
       if (isInstanceOf(childError, Error)) {
         applyExceptionGroupFieldsForParentException(exception, exceptionId, error);
-        const newException = exceptionFromErrorImplementation(parser, childError as Error);
+        const newException = exceptionFromErrorImplementation(parser, childError);
         const newExceptionId = newExceptions.length;
         applyExceptionGroupFieldsForChildException(newException, `errors[${i}]`, newExceptionId, exceptionId);
         newExceptions = aggregateExceptionsFromError(
diff --git a/packages/core/src/utils/is.ts b/packages/core/src/utils/is.ts
@@ -197,11 +197,13 @@ export function isSyntheticEvent(wat: unknown): boolean {
  * @param base A constructor to be used in a check.
  * @returns A boolean representing the result.
  */
-// TODO: fix in v11, convert any to unknown
-// export function isInstanceOf<T>(wat: unknown, base: { new (...args: any[]): T }): wat is T {
-export function isInstanceOf<T>(wat: any, base: any): wat is T {
+type Constructor<T> = { new (...args: never[]): T };
+
+export function isInstanceOf<T>(wat: unknown, base: Constructor<T>): wat is T;
+export function isInstanceOf(wat: unknown, base: unknown): boolean;
+export function isInstanceOf<T>(wat: unknown, base: unknown): wat is T {
   try {
-    return wat instanceof base;
+    return wat instanceof (base as Constructor<T>);
   } catch {
     return false;
   }

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,5 @@`
`2`	`2`	`* Just an Error object with arbitrary attributes attached to it.`
`3`	`3`	`*/`
`4`	`4`	`export interface ExtendedError extends Error {`
`5`		`- // TODO: fix in v11, convert any to unknown`
`6`		`- // eslint-disable-next-line @typescript-eslint/no-explicit-any`
`7`		`- [key: string]: any;`
	`5`	`+ [key: string]: unknown;`
`8`	`6`	`}`