Skip to content

Commit edc87d3

Browse files
logaretmlogaretm
authored
feat(v11): Drop TypeScript 3.8 support (#18604)
### Summary Removes support for generating and publishing TypeScript 3.8 downleveled type definitions across all packages. The changes simplify the build process by eliminating scripts, dependencies, and configuration related to downleveling types, and update test and project configuration accordingly. closes #18477 ### TODO: - [X] Remove all downlevel scripts - [X] Remove all related type declarations in `package.json` - [X] Update and Removed vendored types specific to 3.8 - [X] Target a new minimum TS version > 4.0 - [X] Update TS.38 tests to use the new minimum version --- ⚠️ **Will be parked until v11 is ready to go** ⚠️
1 parent 4878364 commit edc87d3

68 files changed

Lines changed: 81 additions & 766 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.github/workflows/build.yml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -801,7 +801,7 @@ jobs:
801801
include:
802802
# Only check typescript for latest version (to streamline CI)
803803
- node: 24
804-
typescript: '3.8'
804+
typescript: '5.0'
805805
# No need to test orchestrion for v18
806806
- node: 20.19
807807
use_orchestrion: 'true'
@@ -839,8 +839,8 @@ jobs:
839839
dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
840840

841841
- name: Overwrite typescript version
842-
if: matrix.typescript == '3.8'
843-
run: node ./scripts/use-ts-3_8.js
842+
if: matrix.typescript == '5.0'
843+
run: node ./scripts/use-ts-5_0.js
844844
working-directory: dev-packages/node-integration-tests
845845

846846
- name: Run integration tests
@@ -866,7 +866,7 @@ jobs:
866866
include:
867867
# Only check typescript for latest version (to streamline CI)
868868
- node: 24
869-
typescript: '3.8'
869+
typescript: '5.0'
870870
steps:
871871
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
872872
uses: actions/checkout@v7
@@ -882,8 +882,8 @@ jobs:
882882
dependency_cache_key: ${{ needs.job_build.outputs.dependency_cache_key }}
883883

884884
- name: Overwrite typescript version
885-
if: matrix.typescript == '3.8'
886-
run: node ./scripts/use-ts-3_8.js
885+
if: matrix.typescript == '5.0'
886+
run: node ./scripts/use-ts-5_0.js
887887
working-directory: dev-packages/node-core-integration-tests
888888

889889
- name: Run integration tests

‎MIGRATION.md‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,7 @@ Version 11 of the Sentry SDK has new compatibility ranges for runtimes and frame
4040

4141
### TypeScript Version Policy
4242

43-
<!-- TODO(v11): Fill in the final minimum TypeScript version once decided. -->
44-
45-
The minimum required TypeScript version is increased to version `TODO`. We also no longer emit down-leveled types.
43+
The minimum required TypeScript version is increased to version `5.0.4`. We also no longer emit down-leveled types.
4644

4745
Older TypeScript versions _may_ continue to be compatible, but no guarantees apply.
4846

‎dev-packages/e2e-tests/test-applications/create-react-app/package.json‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
"eject": "react-scripts eject",
2020
"clean": "npx rimraf node_modules pnpm-lock.yaml",
2121
"test:build": "pnpm install && pnpm build",
22-
"test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && pnpm build",
2322
"test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && pnpm build",
2423
"test:assert": "pnpm -v"
2524
},
@@ -43,13 +42,5 @@
4342
},
4443
"volta": {
4544
"extends": "../../package.json"
46-
},
47-
"sentryTest": {
48-
"variants": [
49-
{
50-
"build-command": "pnpm test:build-ts3.8",
51-
"label": "create-react-app (TS 3.8)"
52-
}
53-
]
5445
}
5546
}

‎dev-packages/e2e-tests/test-applications/generic-ts3.8/index.ts‎

Lines changed: 0 additions & 5 deletions
This file was deleted.

‎dev-packages/e2e-tests/test-applications/generic-ts3.8/package.json‎

Lines changed: 0 additions & 34 deletions
This file was deleted.

‎dev-packages/e2e-tests/test-applications/generic-ts3.8/tsconfig.json‎

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎dev-packages/e2e-tests/test-applications/react-17/package.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
"test": "playwright test",
2020
"clean": "npx rimraf node_modules pnpm-lock.yaml",
2121
"test:build": "pnpm install && pnpm build",
22-
"test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && pnpm build",
2322
"test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && pnpm build",
2423
"test:assert": "pnpm test"
2524
},

‎dev-packages/e2e-tests/test-applications/react-router-6-descendant-routes/package.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
"test": "playwright test",
2222
"clean": "npx rimraf node_modules pnpm-lock.yaml",
2323
"test:build": "pnpm install && npx playwright install && pnpm build",
24-
"test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && npx playwright install && pnpm build",
2524
"test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && npx playwright install && pnpm build",
2625
"test:assert": "pnpm test"
2726
},

‎dev-packages/e2e-tests/test-applications/react-router-6-use-routes/package.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
"test": "playwright test",
1919
"clean": "npx rimraf node_modules pnpm-lock.yaml",
2020
"test:build": "pnpm install && pnpm build",
21-
"test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && pnpm build",
2221
"test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && pnpm build",
2322
"test:assert": "pnpm test"
2423
},

‎dev-packages/e2e-tests/test-applications/react-router-6/package.json‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
"test": "playwright test",
2222
"clean": "npx rimraf node_modules pnpm-lock.yaml",
2323
"test:build": "pnpm install && pnpm build",
24-
"test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && pnpm build",
2524
"test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && pnpm build",
2625
"test:assert": "pnpm test"
2726
},
@@ -51,13 +50,5 @@
5150
},
5251
"volta": {
5352
"extends": "../../package.json"
54-
},
55-
"sentryTest": {
56-
"variants": [
57-
{
58-
"build-command": "pnpm test:build-ts3.8",
59-
"label": "react-router-6 (TS 3.8)"
60-
}
61-
]
6253
}
6354
}

0 commit comments

Comments
 (0)