fix(lighthouse-ci): upload artifacts from the treosh action's resultsPath output

HazAT · claude · HazAT · commit b29aadaf1bb2 · 2026-05-13T00:11:51.000+02:00
All 27 Lighthouse cells succeeded in CI run db8a4bb but NO PR comment was posted. The Lighthouse Report job logged: Only 0/27 Lighthouse cells have results (< 50%). Skipping comment. Root cause: the upload-artifact step had `path: .lighthouseci/` (in our repo root), but `lhci collect` writes to `.lighthouseci/` inside the treosh action's own working directory (`/home/runner/work/_actions/treosh/ lighthouse-ci-action/.../node_modules/lighthouse-ci/` or similar) \u2014 not our repo root. So the upload step found 0 files, and because of `if-no-files-found: ignore`, silently succeeded with no artifact uploaded. All 27 cells therefore reported "success" while uploading nothing. The treosh action exposes the actual path via its `resultsPath` output. Fix: - Add `id: lighthouse` to the action step. - Switch `path:` to `${{ steps.lighthouse.outputs.resultsPath }}`. - Gate the upload on `resultsPath` being set so a failed Lighthouse run doesn't try to upload nothing. - Switch `if-no-files-found` from `ignore` to `error` so a missing or empty dir is now a loud bug instead of a silent zero-upload. Co-Authored-By: Claude claude-opus-4-5 <noreply@anthropic.com>
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -1307,6 +1307,7 @@ jobs:
           REACT_APP_SENTRY_LIGHTHOUSE_MODE: ${{ matrix.mode }}
 
       - name: Run Lighthouse CI
+        id: lighthouse
         # Pinned to a commit SHA (rather than the floating @v12 tag) to lock down the
         # supply chain: this third-party action also npm-installs @lhci/cli, so an
         # upstream tag-repoint could otherwise change what runs on our runners.
@@ -1329,13 +1330,20 @@ jobs:
           LIGHTHOUSE_URL: 'http://localhost:3000/'
 
       - name: Upload Lighthouse results
+        # `resultsPath` points at the .lighthouseci/ directory inside the treosh action's
+        # own working directory (NOT our repo root — lhci's cwd when the action invokes it
+        # is the action's checkout). Use it explicitly so upload-artifact finds the real
+        # files. Without this, `path: .lighthouseci/` silently finds nothing in our repo
+        # root and `if-no-files-found: ignore` makes the step pass with zero uploaded.
         uses: actions/upload-artifact@v7
-        if: always()
+        if: always() && steps.lighthouse.outputs.resultsPath != ''
         with:
           name: lighthouse-${{ matrix.app }}-${{ matrix.mode }}
-          path: .lighthouseci/
+          path: ${{ steps.lighthouse.outputs.resultsPath }}
           retention-days: 7
-          if-no-files-found: ignore
+          # Fail loudly if the dir is empty — we already gated on resultsPath being set,
+          # so an empty dir means lhci collect produced nothing, which is a real bug.
+          if-no-files-found: error
 
   job_lighthouse_report:
     name: Lighthouse Report
